add longPathAware to shim manifest
#2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevpar
reviewed
Oct 31, 2024
anmaxvl
force-pushed
the
manifest-long-path-support
branch
2 times, most recently
from
615f0af to
edf9033
Compare
kevpar
approved these changes
Oct 31, 2024
Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e. Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
manifest-long-path-support
branch
from
edf9033 to
01194d5
Compare
Contributor
Author
|
repushed, since license/cla was stuck. |
katiewasnothere
approved these changes
Oct 31, 2024
anmaxvl
added a commit
that referenced
this pull request
Oct 29, 2025
Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e. Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit 1c29e9d)
anmaxvl
added a commit
that referenced
this pull request
Oct 29, 2025
…shim manifest add `longPathAware` to shim manifest (#2303) Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e. Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit 1c29e9d) ---- #### AI description (iteration 1) #### PR Classification New feature #### PR Summary This pull request adds long path support to the shim manifest and updates version information. - `cmd/containerd-shim-runhcs-v1/versioninfo.json`: Updated company name, original filename, and product name. - `cmd/containerd-shim-runhcs-v1/containerd-shim-runhcs-v1.exe.manifest`: Added `longPathAware` setting to enable long path support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e.
Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later