Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify go_package in its full path #1345

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Apr 6, 2022

The newer version of protoc-gen-go doesn't support the current form.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

@kzys kzys requested a review from a team as a code owner April 6, 2022 17:20
@dcantah
Copy link
Contributor

dcantah commented Apr 6, 2022

Our linter did not enjoy this for some reason 😰

@kzys
Copy link
Contributor Author

kzys commented Apr 6, 2022

Maybe the time to disable the cache? containerd/containerd@56f95e3

@dcantah
Copy link
Contributor

dcantah commented Apr 6, 2022

Could be, I'm seeing some issues related to staticcheck not playing nice with 1.18 which looks like this run picked up for the go version. google/pprof#662

@dcantah
Copy link
Contributor

dcantah commented Apr 6, 2022

Hmm golangci/golangci-lint#2438. Might be worthwhile to just use 1.17.x instead of ^1.17.0 for our ci maybe until there's support. Let me screw around with this in a branch

@dcantah
Copy link
Contributor

dcantah commented Apr 7, 2022

@kzys Ok a quick rebase and we should be back in business

The newer version of protoc-gen-go doesn't support the current form.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys
Copy link
Contributor Author

kzys commented Apr 11, 2022

@dcantah Thanks! Rebased.

@dcantah dcantah merged commit 8af6c33 into microsoft:master Apr 12, 2022
anmaxvl added a commit that referenced this pull request Feb 7, 2023
Sync ADO with upstream to enable including test GCS binaries as
part of dev-pipeline

Related work items: #1311, #1322, #1341, #1343, #1345, #1347, #1348, #1350, #1353, #1354, #1355, #1358, #1361, #1365, #1368, #1369, #1370
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
The newer version of protoc-gen-go doesn't support the current form.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants