Skip to content

Commit f52091e

Browse files
derrickstoleedscho
authored andcommitted
gvfs-helper: dramatically reduce progress noise
During development, it was very helpful to see the gvfs-helper do its work to request a pack-file or download a loose object. When these messages appear during normal use, it leads to a very noisy terminal output. Remove all progress indicators when downloading loose objects. We know that these can be numbered in the thousands in certain kinds of history calls, and would litter the terminal output with noise. This happens during 'git fetch' or 'git pull' as well when the tip commits are checked for the new refs. Remove the "Requesting packfile with %ld objects" message, as this operation is very fast. We quickly follow up with the more valuable "Receiving packfile %ld%ld with %ld objects". When a large "git checkout" causes many pack-file downloads, it is good to know that Git is asking for data from the server. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
1 parent 2277caf commit f52091e

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

gvfs-helper.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2596,17 +2596,11 @@ static void setup_gvfs_objects_progress(struct gh__request_params *params,
25962596
return;
25972597

25982598
if (params->b_is_post && params->object_count > 1) {
2599-
strbuf_addf(&params->progress_base_phase2_msg,
2600-
"Requesting packfile %ld/%ld with %ld objects",
2601-
num, den, params->object_count);
26022599
strbuf_addf(&params->progress_base_phase3_msg,
26032600
"Receiving packfile %ld/%ld with %ld objects",
26042601
num, den, params->object_count);
2605-
} else {
2606-
strbuf_addf(&params->progress_base_phase3_msg,
2607-
"Receiving %ld/%ld loose object",
2608-
num, den);
26092602
}
2603+
/* If requesting only one object, then do not show progress */
26102604
}
26112605

26122606
/*

0 commit comments

Comments
 (0)