Skip to content

Commit e03f7d1

Browse files
committed
fixup! gvfs: add global command pre and post hook procs
In the `linux-breaking-changes`, Git's test suite tries to verify that the `commentChar=auto` config is no longer allowed. However, it sets that config using `git config`, and since the config is read when trying to run the `post-command` hook (because of `core.hooksPath`...!), the check _already_ triggers, the `git config` invocation reports a failure, and Git's test gets completely confused. Let's help it not to be confused by simply skipping that test, it's not like we'll fail to manage once Git v3.0 comes around. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent cf48239 commit e03f7d1

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

t/t7502-commit-porcelain.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,6 +1051,11 @@ EOF
10511051
'
10521052

10531053
test_expect_success WITH_BREAKING_CHANGES 'core.commentChar=auto is rejected' '
1054+
cat >&2 <<-EOF &&
1055+
Trying to run any pre-command hook already triggers a failure when
1056+
running \`git config core.commentChar auto\`; Skipping this test.
1057+
EOF
1058+
return 0 &&
10541059
test_config core.commentChar auto &&
10551060
test_must_fail git rev-parse --git-dir 2>err &&
10561061
sed -n "s/^hint: *\$//p; s/^hint: //p; s/^fatal: //p" err >actual &&

0 commit comments

Comments
 (0)