Skip to content

Commit d69a3d4

Browse files
Kevin Willforddscho
authored andcommitted
cache-tree: remove use of strbuf_addf in update_one
String formatting can be a performance issue when there are hundreds of thousands of trees. Change to stop using the strbuf_addf and just add the strings or characters individually. There are a limited number of modes so added a switch for the known ones and a default case if something comes through that are not a known one for git. In one scenario regarding a huge worktree, this reduces the time required for a `git checkout <branch>` from 44 seconds to 38 seconds, i.e. it is a non-negligible performance improvement. Signed-off-by: Kevin Willford <kewillf@microsoft.com>
1 parent 9ad7897 commit d69a3d4

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

cache-tree.c

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,29 @@ static int update_one(struct cache_tree *it,
437437
continue;
438438

439439
strbuf_grow(&buffer, entlen + 100);
440-
strbuf_addf(&buffer, "%o %.*s%c", mode, entlen, path + baselen, '\0');
440+
441+
switch (mode) {
442+
case 0100644:
443+
strbuf_add(&buffer, "100644 ", 7);
444+
break;
445+
case 0100664:
446+
strbuf_add(&buffer, "100664 ", 7);
447+
break;
448+
case 0100755:
449+
strbuf_add(&buffer, "100755 ", 7);
450+
break;
451+
case 0120000:
452+
strbuf_add(&buffer, "120000 ", 7);
453+
break;
454+
case 0160000:
455+
strbuf_add(&buffer, "160000 ", 7);
456+
break;
457+
default:
458+
strbuf_addf(&buffer, "%o ", mode);
459+
break;
460+
}
461+
strbuf_add(&buffer, path + baselen, entlen);
462+
strbuf_addch(&buffer, '\0');
441463
strbuf_add(&buffer, oid->hash, the_hash_algo->rawsz);
442464

443465
#if DEBUG_CACHE_TREE

0 commit comments

Comments
 (0)