Skip to content

Commit 959d09f

Browse files
committed
Merge pull request #410: Sparse Index: latest integrations
``` 6e74958 p2000: add 'git checkout -' test and decrease depth 3e1d03c p2000: compress repo names cd94f82 commit: integrate with sparse-index 65e79b8 sparse-index: recompute cache-tree e9a9981 checkout: stop expanding sparse indexes 4b801c8 t1092: document bad 'git checkout' behavior 71e3015 unpack-trees: resolve sparse-directory/file conflicts 5e96df4 t1092: test merge conflicts outside cone defab1b add: allow operating on a sparse-only index 9fc4313 pathspec: stop calling ensure_full_index 0ec03ab add: ignore outside the sparse-checkout in refresh() adf5b15 add: remove ensure_full_index() with --renormalize ``` These commits are equivalent to those already in `next` via gitgitgadget#999. ``` 80b8d6c Merge branch 'sparse-index/add' into stolee/sparse-index/add ``` This merge resolves conflicts with some work that happened in parallel, but is already in upstream `master`. ``` c407b2c t7519: rewrite sparse index test 9dad0d2 sparse-index: silently return when not using cone-mode patterns 2974920 sparse-index: silently return when cache tree fails e7cdaa0 unpack-trees: fix nested sparse-dir search 347410c sparse-checkout: create helper methods 4537233 attr: be careful about sparse directories 5282a86 sparse-index: add SPARSE_INDEX_MEMORY_ONLY flag 3a2f316 sparse-checkout: clear tracked sparse dirs fb47b56 sparse-checkout: add config to disable deleting dirs ``` These commits are the ones under review as of gitgitgadget#1009. Recent review made this less stable. It's a slightly different and more robust version of #396. > Note: I'm still not done with the feedback for upstream, but the remaining feedback is "can we add tests that cover these tricky technical bits?" and in `microsoft/git` these are already covered by the Scalar functional tests (since that's how they were found). ``` 080b02c diff: ignore sparse paths in diffstat d91a647 merge: make sparse-aware with ORT df49b5f merge-ort: expand only for out-of-cone conflicts cdecb85 t1092: add cherry-pick, rebase tests 0c1ecfb sequencer: ensure full index if not ORT strategy 406dfbe sparse-index: integrate with cherry-pick and rebase ``` These commits integrate with `git merge`, `git cherry-pick`, `git revert`, and `git rebase` as of gitgitgadget#1019. This got some feedback that changed how the tests were working so they are more robust. This led to a new commit (0c1ecfb). ``` cbb0ab3 Merge branch 'sparse-index/merge' into vfs-2.33.0 acb8623 t7524: test no longer fails ``` Finally, the commits are merged into `vfs-2.33.0` and also we include a fix to a `microsoft/git` test that is no longer broken.
2 parents 407b49f + 64edce5 commit 959d09f

File tree

6 files changed

+43
-2
lines changed

6 files changed

+43
-2
lines changed

Documentation/config/index.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
index.deleteSparseDirectories::
2+
When enabled, the cone mode sparse-checkout feature will delete
3+
directories that are outside of the sparse-checkout cone, unless
4+
such a directory contains an untracked, non-ignored file. Defaults
5+
to true.
6+
17
index.recordEndOfIndexEntries::
28
Specifies whether the index file should include an "End Of Index
39
Entry" section. This reduces index load time on multiprocessor

builtin/sparse-checkout.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static int sparse_checkout_list(int argc, const char **argv)
102102

103103
static void clean_tracked_sparse_directories(struct repository *r)
104104
{
105-
int i, was_full = 0;
105+
int i, value, was_full = 0;
106106
struct strbuf path = STRBUF_INIT;
107107
size_t pathlen;
108108
struct string_list_item *item;
@@ -118,6 +118,13 @@ static void clean_tracked_sparse_directories(struct repository *r)
118118
!r->index->sparse_checkout_patterns->use_cone_patterns)
119119
return;
120120

121+
/*
122+
* Users can disable this behavior.
123+
*/
124+
if (!repo_config_get_bool(r, "index.deletesparsedirectories", &value) &&
125+
!value)
126+
return;
127+
121128
/*
122129
* Use the sparse index as a data structure to assist finding
123130
* directories that are safe to delete. This conversion to a

diff.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3901,6 +3901,13 @@ static int reuse_worktree_file(struct index_state *istate,
39013901
if (!FAST_WORKING_DIRECTORY && !want_file && has_object_pack(oid))
39023902
return 0;
39033903

3904+
/*
3905+
* If this path does not match our sparse-checkout definition,
3906+
* then the file will not be in the working directory.
3907+
*/
3908+
if (!path_in_sparse_checkout(name, istate))
3909+
return 0;
3910+
39043911
/*
39053912
* Similarly, if we'd have to convert the file contents anyway, that
39063913
* makes the optimization not worthwhile.

t/t1091-sparse-checkout-builtin.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -673,6 +673,10 @@ test_expect_success 'cone mode clears ignored subdirectories' '
673673
git -C repo status --porcelain=v2 >out &&
674674
test_must_be_empty out &&
675675
676+
git -C repo -c index.deleteSparseDirectories=false sparse-checkout reapply &&
677+
test_path_is_dir repo/folder1 &&
678+
test_path_is_dir repo/deep/deeper2 &&
679+
676680
git -C repo sparse-checkout reapply &&
677681
test_path_is_missing repo/folder1 &&
678682
test_path_is_missing repo/deep/deeper2 &&

t/t1092-sparse-checkout-compatibility.sh

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -766,6 +766,23 @@ test_expect_success 'sparse-index is not expanded: merge conflict in cone' '
766766
)
767767
'
768768

769+
test_expect_success 'sparse-index is not expanded: merge conflict in cone' '
770+
init_repos &&
771+
772+
for side in right left
773+
do
774+
git -C sparse-index checkout -b expand-$side base &&
775+
echo $side >sparse-index/deep/a &&
776+
git -C sparse-index commit -a -m "$side" || return 1
777+
done &&
778+
779+
(
780+
sane_unset GIT_TEST_MERGE_ALGORITHM &&
781+
git -C sparse-index config pull.twohead ort &&
782+
ensure_not_expanded ! merge -m merged expand-right
783+
)
784+
'
785+
769786
# NEEDSWORK: a sparse-checkout behaves differently from a full checkout
770787
# in this scenario, but it shouldn't.
771788
test_expect_success 'reset mixed and checkout orphan' '

t/t7524-serialized-status.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ EOF
400400
401401
'
402402

403-
test_expect_failure 'ensure deserialize -v does not crash' '
403+
test_expect_success 'ensure deserialize -v does not crash' '
404404
405405
git init -b main verbose_test &&
406406
touch verbose_test/a &&

0 commit comments

Comments
 (0)