Commit 89c0034
committed
fetch: silence a CodeQL alert about a local variable's address' use after release
As pointed out by CodeQL, it is a potentially dangerous practice to
store local variables' addresses in non-local structs.
My original intention was to make sure to clear it out after it was
used, and before the function returns (which is when the address would
go stale).
However, I faced too much resistance in the Git project against such
patches, there seemed to always be the overwhelming sentiment that the
code isn't broken (even if it requires a complex and demanding analysis
to wrap one's head around _that_). Therefore, I will be pragmatic and
simply ask CodeQL to hold its peace about this issue forever.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>1 parent 9c2cfaa commit 89c0034
1 file changed
+5
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2567 | 2567 | | |
2568 | 2568 | | |
2569 | 2569 | | |
| 2570 | + | |
| 2571 | + | |
| 2572 | + | |
| 2573 | + | |
| 2574 | + | |
2570 | 2575 | | |
2571 | 2576 | | |
2572 | 2577 | | |
| |||
0 commit comments