Skip to content

Commit 820a44f

Browse files
derrickstoleemjcheetham
authored andcommitted
gvfs-helper: dramatically reduce progress noise
During development, it was very helpful to see the gvfs-helper do its work to request a pack-file or download a loose object. When these messages appear during normal use, it leads to a very noisy terminal output. Remove all progress indicators when downloading loose objects. We know that these can be numbered in the thousands in certain kinds of history calls, and would litter the terminal output with noise. This happens during 'git fetch' or 'git pull' as well when the tip commits are checked for the new refs. Remove the "Requesting packfile with %ld objects" message, as this operation is very fast. We quickly follow up with the more valuable "Receiving packfile %ld%ld with %ld objects". When a large "git checkout" causes many pack-file downloads, it is good to know that Git is asking for data from the server. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
1 parent 27bb4f3 commit 820a44f

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

gvfs-helper.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2575,17 +2575,11 @@ static void setup_gvfs_objects_progress(struct gh__request_params *params,
25752575
return;
25762576

25772577
if (params->b_is_post && params->object_count > 1) {
2578-
strbuf_addf(&params->progress_base_phase2_msg,
2579-
"Requesting packfile %ld/%ld with %ld objects",
2580-
num, den, params->object_count);
25812578
strbuf_addf(&params->progress_base_phase3_msg,
25822579
"Receiving packfile %ld/%ld with %ld objects",
25832580
num, den, params->object_count);
2584-
} else {
2585-
strbuf_addf(&params->progress_base_phase3_msg,
2586-
"Receiving %ld/%ld loose object",
2587-
num, den);
25882581
}
2582+
/* If requesting only one object, then do not show progress */
25892583
}
25902584

25912585
/*

0 commit comments

Comments
 (0)