Skip to content

Commit 3eb3cf1

Browse files
committed
fixup! gvfs-helper: create tool to fetch objects using the GVFS Protocol
This fixup updates b46ad0a (gvfs-helper: create tool to fetch objects using the GVFS Protocol, 2019-08-13) in reaction to f6f236d (packfile: refactor `install_packed_git()` to work on packfile store, 2025-09-23) which is included in Git 2.52.0. The refactored packfile store includes an automatic inclusion of new packifles into the MRU list. This introduces a bug in microsoft/git's use of the GVFS protocol in the following scenario in 'git fetch': 1. If the prefetch downloads at least one prefetch packfile, then it is added to the MRU list twice, creating an infinite loop. 2. If the refs that are updated include commits that are not present in the packfile list, then the MRU lookup will iterate through without interruption, hitting the infinite loop. The fix is to modify this patch to no longer include a custom "add to MRU" method now that the default implementation does this for us. Signed-off-by: Derrick Stolee <stolee@gmail.com>
1 parent df57b45 commit 3eb3cf1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gvfs-helper-client.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ static void gh_client__update_packed_git(const char *line)
216216

217217
p = add_packed_git(the_repository, path.buf, path.len, is_local);
218218
if (p)
219-
packfile_store_add_pack_also_to_mru(the_repository, p);
219+
packfile_store_add_pack(the_repository->objects->packfiles, p);
220220
strbuf_release(&path);
221221
}
222222

0 commit comments

Comments
 (0)