Skip to content

Commit 33bea9a

Browse files
committed
Merge pull request #36 Avoid sane_execvp in git rebase and git stash
William Baker reported that the non-built-in rebase and stash fail to run the post-command hook (which is important for VFS for Git, though). The reason is that an `exec()` will replace the current process by the newly-exec'ed one (our Windows-specific emulation cannot do that, and does not even try, so this is only an issue on Linux/macOS). As a consequence, not even the atexit() handlers are run, including the one running the post-command hook. To work around that, let's spawn the legacy rebase/stash and exit with the reported exit code.
2 parents f9410e1 + 20415bd commit 33bea9a

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

builtin/stash.c

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1560,13 +1560,17 @@ int cmd_stash(int argc, const char **argv, const char *prefix)
15601560
};
15611561

15621562
if (!use_builtin_stash()) {
1563-
const char *path = mkpath("%s/git-legacy-stash",
1564-
git_exec_path());
1565-
1566-
if (sane_execvp(path, (char **)argv) < 0)
1567-
die_errno(_("could not exec %s"), path);
1568-
else
1569-
BUG("sane_execvp() returned???");
1563+
struct argv_array args = ARGV_ARRAY_INIT;
1564+
int code;
1565+
1566+
argv_array_push(&args, mkpath("%s/git-legacy-stash",
1567+
git_exec_path()));
1568+
argv_array_pushv(&args, argv + 1);
1569+
code = run_command_v_opt(args.argv, 0);
1570+
if (code < 0)
1571+
die_errno(_("could not exec %s"), args.argv[0]);
1572+
argv_array_clear(&args);
1573+
exit(code);
15701574
}
15711575

15721576
prefix = setup_git_directory();

0 commit comments

Comments
 (0)