fix(react-message-bar): force links to be underlined #32850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
mainframev
force-pushed
the
fix/messagebar-link
branch
from
600c392
to
5caa323
Compare
mainframev
changed the title
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 650 | 612 | 5000 | |
| Button | mount | 317 | 300 | 5000 | |
| Field | mount | 1137 | 1142 | 5000 | |
| FluentProvider | mount | 707 | 751 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 41 | 41 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 77 | 84 | 10 | |
| MakeStyles | mount | 881 | 857 | 50000 | |
| Persona | mount | 1808 | 1759 | 5000 | |
| SpinButton | mount | 1387 | 1412 | 5000 | |
| SwatchPicker | mount | 1700 | 1649 | 5000 |
fabricteam
reviewed
Sep 18, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 11 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 5 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full.chromium.png | 1162 | Changed |
MessageBar 9 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MessageBar.Multiline Without Actions.chromium.png | 67 | Changed |
| MessageBar.Intents.chromium.png | 67 | Changed |
| MessageBar.Multiline No Actions.chromium.png | 67 | Changed |
| MessageBar.Auto.chromium.png | 17 | Changed |
| MessageBar.Multiline.chromium.png | 67 | Changed |
| MessageBar.Intents RTL.chromium.png | 67 | Changed |
| MessageBar.Intents High Contrast.chromium.png | 91 | Changed |
| MessageBar.Square.chromium.png | 17 | Changed |
| MessageBar.Intents Dark Mode.chromium.png | 46 | Changed |
marcosmoura
reviewed
Sep 24, 2024
...ts/react-message-bar/library/src/components/MessageBarBody/useMessageBarBodyStyles.styles.ts
Outdated
Show resolved
Hide resolved
|
This might be unrelated to this PR. But I am wondering if all links should be underlined in the context of the Design System. If that's the case, maybe it would be worth exploring if we can make this change to the |
ling1726
requested changes
Sep 24, 2024
There was a problem hiding this comment.
These kinds of selectors are costy and also fragile - they depend on the styles of the component. Let's introduce a context for this if it only applies to MessageBar. Similar to https://github.com/microsoft/fluentui/blob/master/packages/react-components/react-avatar/library/src/contexts/AvatarContext.ts
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
mainframev
force-pushed
the
fix/messagebar-link
branch
3 times, most recently
from
59c927e
to
7b584c1
Compare
| }; | ||
|
|
||
| export const MessageBarBodyContextProvider = messageBarContext.Provider; | ||
| export const useMessageBarBodyContext = () => React.useContext(messageBarContext) ?? messageBarBodyContextDefaultValue; |
There was a problem hiding this comment.
It should be inverted i.e. react-link has a context provider as in future another component can also tweak Link's behavior
There was a problem hiding this comment.
right, makes sense, updated 👍🏻
mainframev
force-pushed
the
fix/messagebar-link
branch
from
7b584c1
to
090f9c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to design spec links inside MessageBar should be underlined
Previous Behavior
New Behavior
Related Issue(s)