fix(react-message-bar): force links to be underlined #32850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report
Unchanged fixtures
|
mainframev
force-pushed
the
fix/messagebar-link
branch
from
600c392 to
5caa323
Compare
mainframev
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 637 | 628 | 5000 | |
| Button | mount | 308 | 304 | 5000 | |
| Field | mount | 1147 | 1130 | 5000 | |
| FluentProvider | mount | 716 | 705 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 34 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 88 | 73 | 10 | |
| MakeStyles | mount | 872 | 866 | 50000 | |
| Persona | mount | 1738 | 1724 | 5000 | |
| SpinButton | mount | 1393 | 1380 | 5000 | |
| SwatchPicker | mount | 1661 | 1658 | 5000 |
fabricteam
reviewed
Sep 18, 2024
change/@fluentui-react-message-bar-2f896b85-9363-41af-8569-e40177fbae6c.json
Outdated
Show resolved
Hide resolved
marcosmoura
reviewed
Sep 24, 2024
...ts/react-message-bar/library/src/components/MessageBarBody/useMessageBarBodyStyles.styles.ts
Show resolved
Hide resolved
Contributor
|
This might be unrelated to this PR. But I am wondering if all links should be underlined in the context of the Design System. If that's the case, maybe it would be worth exploring if we can make this change to the |
ling1726
previously requested changes
Sep 24, 2024
Contributor
There was a problem hiding this comment.
These kinds of selectors are costy and also fragile - they depend on the styles of the component. Let's introduce a context for this if it only applies to MessageBar. Similar to https://github.com/microsoft/fluentui/blob/master/packages/react-components/react-avatar/library/src/contexts/AvatarContext.ts
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
mainframev
force-pushed
the
fix/messagebar-link
branch
3 times, most recently
from
59c927e to
7b584c1
Compare
packages/react-components/react-message-bar/library/src/contexts/messageBarBodyContext.ts
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
fix/messagebar-link
branch
from
7b584c1 to
090f9c2
Compare
chore(react-link): generate api.md
mainframev
force-pushed
the
fix/messagebar-link
branch
from
090f9c2 to
f164679
Compare
packages/react-components/react-link/library/src/contexts/inlineLinkContext.ts
Outdated
Show resolved
Hide resolved
...-components/react-message-bar/library/src/components/MessageBarBody/renderMessageBarBody.tsx
Outdated
Show resolved
Hide resolved
change/@fluentui-react-link-f1cc3696-e769-47fc-9fed-2ed37e12c28b.json
Outdated
Show resolved
Hide resolved
change/@fluentui-react-message-bar-331d1242-9c7c-49c1-84f0-53757e5e2f45.json
Outdated
Show resolved
Hide resolved
…neLinkContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…8b.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…57e5e2f45.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
packages/react-components/react-link/library/src/components/Link/useLink.ts
Outdated
Show resolved
Hide resolved
...ts/react-message-bar/library/src/components/MessageBarBody/useMessageBarBodyContextValues.ts
Outdated
Show resolved
Hide resolved
...t-components/react-message-bar/library/src/components/MessageBarBody/MessageBarBody.types.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Sep 27, 2024
…nk/useLink.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…ents/MessageBarBody/useMessageBarBodyContextValues.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…ents/MessageBarBody/MessageBarBody.types.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
mainframev
dismissed
ling1726’s stale review
Shift made a review for the same suggestion. Thanks Ling.
marcosmoura
approved these changes
Oct 1, 2024
mltejera
pushed a commit
to mltejera/office-ui-fabric-react
that referenced
this pull request
Oct 3, 2024
Co-authored-by: viktorgenaev <viktorgenaev@microsoft.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to design spec links inside MessageBar should be underlined
Previous Behavior
New Behavior
Related Issue(s)