Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tabs and panel get out of sync when no id is present #5907

Merged
merged 3 commits into from
Apr 28, 2022
Merged

fix: tabs and panel get out of sync when no id is present #5907

merged 3 commits into from
Apr 28, 2022

Conversation

chrisdholt
Copy link
Member

Pull Request

📖 Description

This PR solves an issue where tabs and tab panel elements without ids can get out of sync due to consecutive calls to get the ids. This moves those calls out so they are called once for both tabpanel and tab change methods.

🎫 Issues

n/a - reported offline

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@chrisdholt chrisdholt force-pushed the users/chhol/fix-tabs-and-panel-not-working-together branch from 2d93d06 to cef7120 Compare April 27, 2022 20:04
@chrisdholt chrisdholt force-pushed the users/chhol/fix-tabs-and-panel-not-working-together branch from cef7120 to df0ecdd Compare April 27, 2022 20:05
@chrisdholt chrisdholt added the fast-components:final Issues or PR's to include in the final release of fast-components label Apr 27, 2022
@chrisdholt chrisdholt merged commit 46f9351 into master Apr 28, 2022
@chrisdholt chrisdholt deleted the users/chhol/fix-tabs-and-panel-not-working-together branch April 28, 2022 21:11
huynhicode pushed a commit that referenced this pull request Apr 29, 2022
@chrisdholt @huynhicode
ensure tab and tabpanel instances without ids do not go out of sync d…
7889d18 
…ue to separate consecutive calls (#5907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scomea scomea scomea approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@janechu janechu Awaiting requested review from janechu

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees
No one assigned
Labels
fast-components:final Issues or PR's to include in the final release of fast-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdholt @EisenbergEffect @scomea