fix: vertical tabs from jumping #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5398.centralus.azurestaticapps.net |
eljefe223
force-pushed
the
users/jes/vertical-tabs-styling
branch
from
70f8f6f to
b017649
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5398.centralus.azurestaticapps.net |
scomea
approved these changes
Nov 18, 2021
eljefe223
force-pushed
the
users/jes/vertical-tabs-styling
branch
from
b017649 to
2e65a13
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5398.centralus.azurestaticapps.net |
EisenbergEffect
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Vertically aligns the
tablistto the top so it does not jump around when tabpanels have various length content.🎫 Issues
Closes: #5389
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps