Fix/remove non null assertion #5353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4thieulavoie
requested review from
chrisdholt,
EisenbergEffect,
janechu and
nicholasrice
as code owners
Change files
m4thieulavoie
force-pushed
the
fix/remove-non-null-assertion
branch
from
c0358b4 to
3b2a093
Compare
scomea
approved these changes
Nov 2, 2021
robarbms
approved these changes
Nov 2, 2021
packages/web-components/fast-components/src/anchored-region/anchored-region.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/fast-components/src/anchored-region/anchored-region.stories.ts
Outdated
Show resolved
Hide resolved
…chored-region.stories.ts Co-authored-by: Rob Barber <69695238+robarbms@users.noreply.github.com>
…chored-region.stories.ts Co-authored-by: Rob Barber <69695238+robarbms@users.noreply.github.com>
chrisdholt
approved these changes
Nov 5, 2021
|
@m4thieulavoie looks like prettier and lint may be failing - can you try and run locally? |
Sure! Will get back at it either today or this weekend, sorry for the delay 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR removes the non-null assertions in the anchor region storybook file.
🎫 Issues
Fixes #5340
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps