fix: use a merge strategy for oneOf/anyOfs during validation #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
force-pushed
the
users/janechu/add-merge-ability-for-oneOf-anyOfs
branch
2 times, most recently
from
04de5a5 to
f87f389
Compare
eljefe223
approved these changes
Apr 18, 2019
eljefe223
approved these changes
Apr 18, 2019
janechu
force-pushed
the
users/janechu/add-merge-ability-for-oneOf-anyOfs
branch
from
f87f389 to
1968ffb
Compare
nicholasrice
approved these changes
Apr 19, 2019
janechu
force-pushed
the
users/janechu/add-merge-ability-for-oneOf-anyOfs
branch
2 times, most recently
from
1c846e3 to
00b6ef2
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
warning:stale
janechu
force-pushed
the
users/janechu/add-merge-ability-for-oneOf-anyOfs
branch
from
00b6ef2 to
1dbe290
Compare
stale
bot
removed
the
warning:stale
|
Code Climate has analyzed commit 1dbe290 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 61.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.5% (0.2% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses a merge to correctly validate against oneOf/anyOf subschemas.
Motivation & context
Resolves #1684
Issue type checklist
Is this a breaking change?
Process & policy checklist