Skip to content

Commit 1ec4249

Browse files
committed
Resolve TODO comments for unexpected event warnings
Replace 5 'TODO: Should this be an error?' comments with descriptive explanations noting these can happen during replay or duplicate event delivery. The warning logs are already correctly implemented for all event types (timerFired, taskCompleted, taskFailed, subOrchestrationInstanceCompleted, subOrchestrationInstanceFailed).
1 parent c172c81 commit 1ec4249

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

durabletask/worker.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1437,7 +1437,7 @@ def process_event(
14371437
timer_id = event.timerFired.timerId
14381438
timer_task = ctx._pending_tasks.pop(timer_id, None)
14391439
if not timer_task:
1440-
# TODO: Should this be an error? When would it ever happen?
1440+
# This can happen during replay or if a duplicate event is delivered
14411441
if not ctx._is_replaying:
14421442
self._logger.warning(
14431443
f"{ctx.instance_id}: Ignoring unexpected timerFired event with ID = {timer_id}."
@@ -1491,7 +1491,7 @@ def process_event(
14911491
task_id = event.taskCompleted.taskScheduledId
14921492
activity_task = ctx._pending_tasks.pop(task_id, None)
14931493
if not activity_task:
1494-
# TODO: Should this be an error? When would it ever happen?
1494+
# This can happen during replay or if a duplicate event is delivered
14951495
if not ctx.is_replaying:
14961496
self._logger.warning(
14971497
f"{ctx.instance_id}: Ignoring unexpected taskCompleted event with ID = {task_id}."
@@ -1506,7 +1506,7 @@ def process_event(
15061506
task_id = event.taskFailed.taskScheduledId
15071507
activity_task = ctx._pending_tasks.pop(task_id, None)
15081508
if not activity_task:
1509-
# TODO: Should this be an error? When would it ever happen?
1509+
# This can happen during replay or if a duplicate event is delivered
15101510
if not ctx.is_replaying:
15111511
self._logger.warning(
15121512
f"{ctx.instance_id}: Ignoring unexpected taskFailed event with ID = {task_id}."
@@ -1560,7 +1560,7 @@ def process_event(
15601560
task_id = event.subOrchestrationInstanceCompleted.taskScheduledId
15611561
sub_orch_task = ctx._pending_tasks.pop(task_id, None)
15621562
if not sub_orch_task:
1563-
# TODO: Should this be an error? When would it ever happen?
1563+
# This can happen during replay or if a duplicate event is delivered
15641564
if not ctx.is_replaying:
15651565
self._logger.warning(
15661566
f"{ctx.instance_id}: Ignoring unexpected subOrchestrationInstanceCompleted event with ID = {task_id}."
@@ -1578,7 +1578,7 @@ def process_event(
15781578
task_id = failedEvent.taskScheduledId
15791579
sub_orch_task = ctx._pending_tasks.pop(task_id, None)
15801580
if not sub_orch_task:
1581-
# TODO: Should this be an error? When would it ever happen?
1581+
# This can happen during replay or if a duplicate event is delivered
15821582
if not ctx.is_replaying:
15831583
self._logger.warning(
15841584
f"{ctx.instance_id}: Ignoring unexpected subOrchestrationInstanceFailed event with ID = {task_id}."

0 commit comments

Comments
 (0)