-
Notifications
You must be signed in to change notification settings - Fork 16
Fixing various test issues for all tests #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bletask-java into wangbill/test-fix
This reverts commit a9fe0d6.
This reverts commit 10c3930.
… annotations to use @RetryingTest and @RetryingParameterizedTest, and included TestRetryExtension for improved error handling during test execution.
This commit introduces a new protobuf file defining the orchestrator service, including messages for orchestration instances, activity requests and responses, task failure details, and various orchestration events. The new definitions facilitate communication within the Durable Task framework, enabling orchestration management and event handling.
kaibocai7
approved these changes
Mar 20, 2025
kaibocai
approved these changes
Mar 20, 2025
JoshVanL
pushed a commit
to JoshVanL/durabletask-java
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipelines tests are failing, this pr fixes flaky tests and any test setup issues
Issue describing the changes in this PR
This pull request includes several important changes to the
clientmodule, specifically in thebuild.gradlefile and theIntegrationTests.javafile. The changes aim to improve the test setup and enhance the robustness of the integration tests.Build Configuration:
PATH_TO_TEST_JAVA_RUNTIMEdefinition to use the system environment variableJDK_11or fall back to the system propertyjava.homeif the environment variable is not set. (client/build.gradle)Integration Tests Enhancements:
@BeforeEachmethod to delete the task hub before each test to ensure a clean state. (client/src/test/java/com/microsoft/durabletask/IntegrationTests.java)multiInstanceQuerytest to account for potential clock drift between client and backend timestamps. (client/src/test/java/com/microsoft/durabletask/IntegrationTests.java)multiInstanceQuerytest to provide more detailed failure messages and ensure accurate filtering of instances based on timestamps. (client/src/test/java/com/microsoft/durabletask/IntegrationTests.java)CreatedTimeFromandCreatedTimeTocriteria in thepurgeInstanceFiltertest to account for potential timing issues. (client/src/test/java/com/microsoft/durabletask/IntegrationTests.java)resolves #issue_for_this_pr
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information