Remove unreachable code (#613)

Author: chlowell

src/ApiPort/ApiPort/EmptyDependencyFinder.cs

@@ -81,14 +81,6 @@ public Task<ServiceResponse<IEnumerable<AvailableTarget>>> GetTargetsAsync()
             return Task.FromResult(response);
         }
 
-        public Task<ServiceResponse<UsageDataCollection>> GetUsageDataAsync(int? skip = default(int?), int? top = default(int?), UsageDataFilter? filter = default(UsageDataFilter?), IEnumerable<string> targets = null)
-        {
-            _progress.ReportIssue(LocalizedStrings.FileOutputServiceNotSupported);
-            var response = ServiceResponse.Create(new UsageDataCollection());
-
-            return Task.FromResult(response);
-        }
-
         public Task<ServiceResponse<IReadOnlyCollection<ApiInformation>>> QueryDocIdsAsync(IEnumerable<string> docIds)
         {
             _progress.ReportIssue(LocalizedStrings.FileOutputServiceNotSupported);

src/ApiPort/ApiPort/FileOutputApiPortService.cs

@@ -106,11 +106,6 @@ private static Task<ServiceResponse<T>> WrapResponse<T>(T data)
             return Task.FromResult(response);
         }
 
-        public Task<ServiceResponse<UsageDataCollection>> GetUsageDataAsync(int? skip = null, int? top = null, UsageDataFilter? filter = null, IEnumerable<string> targets = null)
-        {
-            throw new NotImplementedException();
-        }
-
         public static Task<ServiceResponse<AnalyzeResponse>> GetAnalysisAsync(string submissionId)
         {
             throw new NotImplementedException();

src/ApiPort/ApiPort/Modules/DataTransferModule.cs

@@ -35,8 +35,6 @@ public class ApiPortClient
         private readonly IEnumerable<IgnoreAssemblyInfo> _assembliesToIgnore;
         private readonly IFileWriter _writer;
 
-        public ITargetMapper TargetMapper { get { return _targetMapper; } }
-
         public ApiPortClient(IApiPortService apiPortService, IProgressReporter progressReport, ITargetMapper targetMapper, IDependencyFinder dependencyFinder, IReportGenerator reportGenerator, IEnumerable<IgnoreAssemblyInfo> assembliesToIgnore, IFileWriter writer)
         {
             _apiPortService = apiPortService;
@@ -48,32 +46,6 @@ public ApiPortClient(IApiPortService apiPortService, IProgressReporter progressR
             _writer = writer;
         }
 
-        /// <summary>
-        /// Analyzes assemblies provided by options
-        /// </summary>
-        /// <param name="options"></param>
-        /// <returns>A reporting result for the supplied assemblies</returns>
-        public async Task<ReportingResult> AnalyzeAssembliesAsync(IApiPortOptions options)
-        {
-            ValidateOptions(options);
-
-            var assemblies = options.InputAssemblies?.Keys ?? Array.Empty<IAssemblyFile>();
-            var dependencyInfo = _dependencyFinder.FindDependencies(assemblies, _progressReport);
-
-            if (dependencyInfo.UserAssemblies.Any())
-            {
-                AnalyzeRequest request = GenerateRequest(options, dependencyInfo);
-
-                return await GetResultFromServiceAsync(request, dependencyInfo);
-            }
-            else
-            {
-                _progressReport.ReportIssue(LocalizedStrings.NoFilesAvailableToUpload);
-
-                return null;
-            }
-        }
-
         /// <summary>
         /// Retrieve a list of targets available from the service
         /// </summary>
@@ -332,19 +304,6 @@ private AnalyzeRequest GenerateRequest(IApiPortOptions options, IDependencyInfo
             };
         }
 
-        /// <summary>
-        /// Gets the Portability of an application as a ReportingResult.
-        /// </summary>
-        /// <returns>Set of APIs/assemblies that are not portable/missing.</returns>
-        private async Task<ReportingResult> GetResultFromServiceAsync(AnalyzeRequest request, IDependencyInfo dependencyInfo)
-        {
-            var fullResponse = await RetrieveResultAsync(request);
-
-            CheckEndpointStatus(fullResponse.Headers.Status);
-
-            return GetReportingResult(request, fullResponse.Response, dependencyInfo);
-        }
-
         private ReportingResult GetReportingResult(AnalyzeRequest request, AnalyzeResponse response, IDependencyInfo dependencyInfo)
         {
             if (response == null)
@@ -376,22 +335,6 @@ private ReportingResult GetReportingResult(AnalyzeRequest request, AnalyzeRespon
             }
         }
 
-        private async Task<ServiceResponse<AnalyzeResponse>> RetrieveResultAsync(AnalyzeRequest request)
-        {
-            using (var progressTask = _progressReport.StartTask(LocalizedStrings.AnalyzingCompatibility))
-            {
-                try
-                {
-                    return await _apiPortService.SendAnalysisAsync(request);
-                }
-                catch (Exception)
-                {
-                    progressTask.Abort();
-                    throw;
-                }
-            }
-        }
-
         /// <summary>
         /// Verifies that the service is alive.  If the service is not alive, then an issue is logged
         /// that will be reported back to the user.

src/lib/Microsoft.Fx.Portability.Offline/OfflineApiPortService.cs

@@ -71,18 +71,6 @@ public async Task<ServiceResponse<IEnumerable<AvailableTarget>>> GetTargetsAsync
             return await _client.CallAsync<IEnumerable<AvailableTarget>>(HttpMethod.Get, Endpoints.Targets);
         }
 
-        public async Task<ServiceResponse<UsageDataCollection>> GetUsageDataAsync(int? skip = null, int? top = null, UsageDataFilter? filter = null, IEnumerable<string> targets = null)
-        {
-            var usedApiUrl = UrlBuilder.Create(Endpoints.UsedApi)
-                .AddQuery("skip", skip)
-                .AddQuery("top", top)
-                .AddQuery("filter", filter)
-                .AddQueryList("targets", targets)
-                .Url;
-
-            return await _client.CallAsync<UsageDataCollection>(HttpMethod.Get, usedApiUrl);
-        }
-
         public async Task<ServiceResponse<AnalyzeResponse>> GetAnalysisAsync(string submissionId)
         {
             var submissionUrl = UrlBuilder.Create(Endpoints.Analyze).AddPath(submissionId).Url;

src/lib/Microsoft.Fx.Portability/ApiPortClient.cs

@@ -12,7 +12,6 @@ public interface IApiPortService
         Task<ServiceResponse<IEnumerable<AvailableTarget>>> GetTargetsAsync();
         Task<ServiceResponse<AnalyzeResponse>> SendAnalysisAsync(AnalyzeRequest a);
         Task<ServiceResponse<IEnumerable<ReportingResultWithFormat>>> SendAnalysisAsync(AnalyzeRequest a, IEnumerable<string> format);
-        Task<ServiceResponse<UsageDataCollection>> GetUsageDataAsync(int? skip = null, int? top = null, UsageDataFilter? filter = null, IEnumerable<string> targets = null);
         Task<ServiceResponse<ApiInformation>> GetApiInformationAsync(string docId);
         Task<ServiceResponse<IReadOnlyCollection<ApiDefinition>>> SearchFxApiAsync(string query, int? top = null);
         Task<ServiceResponse<IEnumerable<ResultFormatInformation>>> GetResultFormatsAsync();

src/lib/Microsoft.Fx.Portability/ApiPortService.cs

@@ -13,6 +13,5 @@ public interface IStorage
         Task<IEnumerable<string>> RetrieveSubmissionIdsAsync();
         Task AddJobToQueueAsync(string submissionId);
         IEnumerable<ProjectSubmission> GetProjectSubmissions();
-        Task<IEnumerable<UsageData>> GetUsageDataAsync();
     }
 }