Add background elevated process for setup flow #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
requested review from
EricJohnson327,
AmelBawa-msft,
bbonaby and
dhoehna
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # tools/SetupFlow/DevHome.SetupFlow.RepoConfig/Models/CloneRepoTask.cs # tools/SetupFlow/DevHome.SetupFlow.Summary/ViewModels/SummaryViewModel.cs # tools/SetupFlow/DevHome.SetupFlow.UnitTest/ViewModels/SearchViewModelTest.cs
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # src/DevHome.csproj # tools/SetupFlow/DevHome.SetupFlow.Common/Services/SetupFlowOrchestrator.cs # tools/SetupFlow/DevHome.SetupFlow.Common/ViewModels/SetupPageViewModelBase.cs # tools/SetupFlow/DevHome.SetupFlow.Summary/ViewModels/SummaryViewModel.cs # tools/SetupFlow/DevHome.SetupFlow/ViewModels/SetupFlowViewModel.cs
# Conflicts: # DevHome.sln # tools/SetupFlow/DevHome.SetupFlow.AppManagement/Models/InstallPackageTask.cs
# Conflicts: # DevHome.sln # src/DevHome.csproj
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...SetupFlow.ElevatedComponent.Projection/DevHome.SetupFlow.ElevatedComponent.Projection.csproj
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow.ElevatedComponent.Setup/IPCSetup.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow.ElevatedComponent/ElevatedComponentFactory.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow.ElevatedComponent.Setup/IPCSetup.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow.Summary/ViewModels/SummaryViewModel.cs
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow.UnitTest/BackgroundProcessTest.cs
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Mar 29, 2023
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> |
There was a problem hiding this comment.
Given this is its own exe, you are probably going to have to make this self-contained too similar to the main dev home app via a publish profile.
tools/SetupFlow/DevHome.SetupFlow.ElevatedComponent.Setup/IPCSetup.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow.ElevatedComponent/ElevatedComponentFactory.cs
Show resolved
Hide resolved
|
I've tested this and worked with Flor to confirm it works as intended to create dev drives. @AmelBawa-msft I believe you should be able to install apps with this as well, but you'll have to test it out. I'm sure if there are any runtime problems we'll continue to iterate on this. As currently constructed I have no problems. @manodasanW are you able to take a look again? For me I can approve once the merge conflicts are solved |
AmelBawa-msft
approved these changes
Mar 30, 2023
# Conflicts: # tools/SetupFlow/DevHome.SetupFlow.AppManagement/Models/InstallPackageTask.cs # tools/SetupFlow/DevHome.SetupFlow.Common/Models/ISetupTask.cs # tools/SetupFlow/DevHome.SetupFlow.Loading/ViewModels/LoadingViewModel.cs # tools/SetupFlow/DevHome.SetupFlow.RepoConfig/Models/CloneRepoTask.cs
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Added a process that runs elevated in the background during the setup flow to execute any tasks that require admin permissions. Having this background process to offload work to lets us have a single UAC prompt when starting the setup.
References and relevant issues
Detailed description of the pull request / Additional comments
When starting the setup, if any of the tasks to execute requires admin, we start this process and establish communication with it by having an object on the background process and a proxy for it on the main app process. The interface for this object can be extended as needed for all the tasks that need admin (install apps, create dev drive). See the comment at the top of IPCSetup.cs for details of how this is set up.
Extended the ISetupTask interface with an ExecuteAsAdmin() method. This method takes the remote factory as a parameter. To implement it, one would add a new type to the elevated component to handle the required steps, add a corresponding Create*() method on the factory interface to create an object of that type, and then use that in the ExecuteAsAdmin() method.
Validation steps performed
As there are no current implementations for tasks that run as admin, I temporarily modified the code to always launch the elevated process when starting the setup and added a test method to print a string. Manually verified that the process was started, and that calling the test method from the main app would print the message on the elevated process' windows.
Added a test that starts the process, calls this test method to print something, then checks the process output.
PR checklist
Closes #xxxNo related issue