Respect app specific requested theme in customization dialogs #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonaby
approved these changes
Sep 3, 2024
zadesai
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Set requested theme in modify features and restart dialog in Windows customization so that the Dev Home theme override is applied instead of the Windows system theme.
References and relevant issues
#3749
Detailed description of the pull request / Additional comments
Validation steps performed
Ensure Windows theme is set to light
Open Dev Home App.
Apply dark theme (Settings -> Preference -> Theme -> Dark).
Now Go to "Windows Customization" page (Select form the navigation options).
Select any of the options and click on "Apply" button.
Observe "Committing changes" pop up complies with Dev Home settings theme and not that of Windows, i.e. is Dark
PR checklist