Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WSL extension to use default windows terminal/console to launch and install distributions #3742

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

bbonaby
Copy link
Contributor

@bbonaby bbonaby commented Sep 3, 2024

Summary of the pull request

This PR fixes an issue where the wsl extension was launching into the release version of the Windows terminal app and not honoring the default terminal app set by the user.

  • This fixes an issue where the Windows terminal app may not exist or is a stub app.
    Changes:

  • Use wsl.exe directly instead of attempting to launch wt.exe with the distributions terminal profile. E.g attempting to launch the ubuntu distribution with its shipped profile. Spoke to Mike from the terminal team, to confirm that we shouldn't need to use wt.exe directly and that terminal should be able to figure it out on its own. Terminal ships with a profile for ubuntu itself. However, there is an issue where ubuntu isn't launched with its profile even when terminal is the default when launching the wsl.exe directly. The issue should be resolved once this issue is figured out in the terminal repo WSL profile matching fails to work if launched from start menu terminal#12582, but for now we should stick with just calling wsl.exe directly rather than through wt.exe.

Video of me going from a state where my computer doesn't have terminal installed and launching a WSL distribution, to installing both Terminal release and Terminal Preview. The video shows that after changing my default terminal host, Dev Home is able to launch the WSL distribution using the correct terminal version.

Video.showing.WSL.distirbution.launching.into.the.users.default.terminal.mp4

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@bbonaby bbonaby changed the title Allow WSL and Dev home to use the default terminal application when launching terminal Allow WSL extension to use default windows terminal/console to launch and install distributions Sep 3, 2024
@bbonaby bbonaby merged commit 4feeb45 into main Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants