Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dev Insights to final Dev Diagnostics name #3738

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

andreww-msft
Copy link
Contributor

Summary of the pull request

Also updated the temporary icon.

Closes #3322
Closes #3725

src/Properties/launchsettings.json Outdated Show resolved Hide resolved
tools/DevDiagnostics/DevHome.DevDiagnostics/DDApp.xaml.cs Outdated Show resolved Hide resolved
</setting>
</DevHome.DevInsights.Properties.Settings>
</userSettings>
<?xml version="1.0" encoding="utf-8" ?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of files got their line endings changed. This one at least is LF now, should be put back to CRLF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I'm seeing CRLF in this file and others...???

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@xhan65 xhan65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andreww-msft andreww-msft merged commit 15491ce into main Sep 3, 2024
4 checks passed
@andreww-msft andreww-msft deleted the user/andreww/devDiagnostics-rename branch September 3, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants