Fix focus transition issues related to dialogs and UAC in Virtualization #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
Aug 19, 2024
tools/Customization/DevHome.Customization/Views/ModifyFeaturesDialog.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/RestartDialog.xaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
dhoehna
reviewed
Aug 20, 2024
dhoehna
reviewed
Aug 20, 2024
dhoehna
approved these changes
Aug 20, 2024
krschau
reviewed
Aug 21, 2024
| <comment>Message instructing the user to restart their machine to apply changes</comment> | ||
| </data> | ||
| <data name="RestartDialog.PrimaryButtonText" xml:space="preserve"> | ||
| <value>Restart now</value> |
There was a problem hiding this comment.
Just a random thought. Is it clear to the user that this is to restart the machine and not just DevHome?
There was a problem hiding this comment.
that's a good question. I'll follow up with our content writer to see if more clarity is needed there.
vineeththomasalex
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This change ensures the narrator reads the committing changes and restart dialog without manual reapplication of focus.
The progress modal dialog is disrupted by a race with the UAC prompt focusing the narrator. Additionally, having one content dialog that shares two presentations make this difficult to orchestrate with focus and accessibility, to simplify things, the modify features dialog is split:
References and relevant issues
#3639
Detailed description of the pull request / Additional comments
Validation steps performed
Apply a feature with narrator enabled
PR checklist