Announcing widget errors and warnings #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
krschau,
dkbennett,
AmelBawa-msft,
dhoehna and
vineeththomasalex
dhoehna
reviewed
May 31, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/WidgetViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
May 31, 2024
added 2 commits
May 31, 2024 11:06
krschau
reviewed
Jun 4, 2024
dhoehna
reviewed
Jun 4, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/WidgetViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Jun 4, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/WidgetViewModel.cs
Outdated
Show resolved
Hide resolved
EricJohnson327
approved these changes
Jun 5, 2024
dkbennett
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
When we have a warning inside a widget, or an error message, the narrator should announce this event to the user, reading the message for them.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/48793024
Detailed description of the pull request / Additional comments
This changes adds a linear search on the widget whenever it is rendered, looking for potential warning messages, which here are any TextBlocks inside containers with
warningstyle. When found, we use the announcement service to narrate it to the user.In the case of an error card, all the message is announced to the user when rendered.
Validation steps performed
PR checklist