Adding tooltips to NavigationViewItems on AddWidget dialog #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
dhoehna,
dkbennett,
krschau,
EricJohnson327 and
AmelBawa-msft
krschau
approved these changes
May 15, 2024
vineeththomasalex
approved these changes
May 15, 2024
EricJohnson327
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds tooltips to the menu items in the
AddWidgetDialogpage.References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49360580
https://dev.azure.com/microsoft/OS/_workitems/edit/50153016
Detailed description of the pull request / Additional comments
If the string have too many characters, the text will be clipped on the
NavigtationViewItemon theAddWidgetDialogpage. This can also happen when the user needs to scale up the size of the text to 200% for example. Limiting the size of the strings is also problematic because of changes on the size due to localization to other languages.This issue also appears externally from Dev Home, on the Windows 11 start menu for example. And the way they worked around this is adding tooltips that can fully show the intended string.
Validation steps performed
PR checklist