Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing Project Ironsides into Dev Home #2887

Merged
merged 13 commits into from
May 15, 2024
Merged

Conversation

jaholme
Copy link
Contributor

@jaholme jaholme commented May 10, 2024

Summary of the pull request

This PR adds the Project Ironsides experimental feature to Dev Home.

References and relevant issues

#2796

Detailed description of the pull request / Additional comments

As described in #2796 this brings in the initial scaffolding for Dev Home PI(Project Ironsides) a new feature to allow deeper investigation into applications.

Project Ironsides when enabled in Dev Home experimental settings shows up in the Utilites section of Dev Home.

Validation steps performed

Full build has been kicked off internally to validate the changes.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Jason Holmes and others added 2 commits May 10, 2024 17:01
…o fix version mismatch warning.

The following warning is due to referencing the version of System.Drawing.Common another component includes.  This change updates the version to 8.0.0.0 and gets rid of the warning.

Verified:
1. Build no longer prints warning.
2. PI launches with no issues.

warning MSB3277: Found conflicts between different versions of "System.Drawing.Common" that could not be resolved.
warning MSB3277: There was a conflict between "System.Drawing.Common, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" and "System.Drawing.Common, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51".
warning MSB3277:     "System.Drawing.Common, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" was chosen because it was primary and "System.Drawing.Common, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" was not.
warning MSB3277:     References which depend on "System.Drawing.Common, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" [E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll].
warning MSB3277:         E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll
warning MSB3277:           Project file item includes which caused reference "E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll".
warning MSB3277:             E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll
warning MSB3277:     References which depend on or have been unified to "System.Drawing.Common, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" [].
warning MSB3277:         E:\repos\DevHome\packages\system.windows.extensions\8.0.0\lib\net8.0\System.Windows.Extensions.dll
warning MSB3277:           Project file item includes which caused reference "E:\repos\DevHome\packages\system.windows.extensions\8.0.0\lib\net8.0\System.Windows.Extensions.dll".
warning MSB3277:             E:\repos\DevHome\packages\system.windows.extensions\8.0.0\lib\net8.0\System.Windows.Extensions.dll
warning MSB3277:             E:\repos\DevHome\packages\system.security.permissions\8.0.0\lib\net8.0\System.Security.Permissions.dll
warning MSB3277:             E:\repos\DevHome\packages\system.directoryservices\8.0.0\lib\net8.0\System.DirectoryServices.dll
src/Package.appxmanifest Outdated Show resolved Hide resolved
src/Program.cs Outdated Show resolved Hide resolved
tools/PI/DevHome.PI/BarWindow.xaml Outdated Show resolved Hide resolved
tools/PI/DevHome.PI/BarWindow.xaml.cs Show resolved Hide resolved
src/Program.cs Outdated Show resolved Hide resolved
jaholme and others added 2 commits May 14, 2024 12:51
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
@jaholme jaholme merged commit 0533974 into main May 15, 2024
4 checks passed
@jaholme jaholme deleted the feature/projectironsides branch May 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants