Populate ComSafeWidgets after creation, handle failures #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
reviewed
Apr 25, 2024
| } | ||
| catch (Exception ex) | ||
| { | ||
| Log.Warning(ex, $"Failed to operate on out-of-proc object with error code: 0x{ex.HResult:x}"); |
There was a problem hiding this comment.
Is this exception coming from COM, or the OOP object? If from the object, any exception is returned as a Generic Exception and the message will also be "Generic Exception"
There was a problem hiding this comment.
I'm specifically worried about COM, I don't think we're expecting we can get any other exception here from the object.
dhoehna
approved these changes
Apr 25, 2024
EricJohnson327
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Fixes issue where we were able to pin multiples of widgets where AllowMultiple = false, maybe other ones not yet found.
With lazy loading, ComSafeWidgets were only loaded with properties when a method was called on them. In the case that a property was called first, the ComSafeWidget didn't have its properties set, and would return the default (which, in the case of AllowMultiple, is true). We should call PopulateAsync() on all ComSafe* objects after new-ing them up. This was already done for ComSafeWidgetDefinitions.
Validation steps performed
Validated locally.
PR checklist