Move Dev Home to WAP Project to support upcoming features #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaholme
requested review from
nieubank,
aeloros,
andreww-msft,
dabhattimsft,
krschau,
timkur,
EricJohnson327 and
zadesai
krschau
reviewed
Apr 23, 2024
krschau
reviewed
Apr 24, 2024
jaholme
commented
Apr 24, 2024
dhoehna
reviewed
Apr 24, 2024
dhoehna
approved these changes
Apr 24, 2024
zadesai
approved these changes
Apr 24, 2024
added 5 commits
April 24, 2024 15:49
…rrect appxmanifest source that was lost in latest tests
krschau
approved these changes
Apr 26, 2024
EricJohnson327
approved these changes
Apr 26, 2024
dabhattimsft
pushed a commit
that referenced
this pull request
May 7, 2024
)" This reverts commit a21a3d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This change moves the Dev Home project over to WAP Project to support upcoming features.
The main changes are the way the build.ps1 script generates the msix packages as well as a couple of unfortunate changes needed to the AppXManifest to explicitly list resource languages supported.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Ran build pipeline and validated that the installed package was correct.
Verified sources are localized correctly.
PR checklist