Adding AutomationProperties.Name string to dashboard page #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
krschau,
dhoehna,
AmelBawa-msft,
dkbennett and
vineeththomasalex
krschau
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Is this a problem because we're not using the built-in header on this page? (I think a way to check would be if Extensions page does not have this problem -- it uses the built-in header). I'd also be curious what happens on the Settings pages. They use a "real" header, but its a BreadcrumbBar, not just a string.
|
@krschau Actually every single page have this problem in Dev Home, but I don't think there is a one fix for all. I was thinking of having this in the Tool Page code to get the localized string, but in the end, it would be more code than just adding the AutomationProperties.Name for each page. |
AmelBawa-msft
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds an accessible name to the Dashboard Tool Page.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49356719
Detailed description of the pull request / Additional comments
When the user first focus a control inside the dashboard page, it should narrates the title of the page, so the user knows in which page it is in.
Validation steps performed
PR checklist