-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert logging solution to Serilog #2474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Pull request contains merge conflicts. |
krschau
reviewed
Mar 27, 2024
HyperVExtension/src/HyperVExtension.Common/HyperVExtension.Common.csproj
Show resolved
Hide resolved
dhoehna
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in my area.
vineeththomasalex
approved these changes
Mar 27, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Converts all logging infrastructure in Dev Home over to using Serilog. This conversion is a 1:1 translation for the most part, removing the old in-house logging solution and replacing it with Serilog. Further optimizations and improvements can be made now that the logging is moved to a more consistent paradigm with Serilog. This also works much better with Dependency Injection, which is one of the foreseen next steps following this conversion.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist