Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional scroll regions #2445

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Fix additional scroll regions #2445

merged 4 commits into from
Mar 25, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Mar 20, 2024 •
edited
Loading

Summary of the pull request

Fix a couple things missed in #2423:

  • Fix scroll regions for ExtensionSettingsPage
  • Fix margins in SetupFlow's SetupShell and Environments's LandingPage so that the header and content isn't taking up the whole MaxWidth

And

  • Removed a temporary debugging border that accidentally got left in

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau added the Needs-Second Pull request that needs another approval label Mar 21, 2024
adrastogi
adrastogi approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@adrastogi adrastogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krschau krschau merged commit e93c8fe into main Mar 25, 2024
4 checks passed
@krschau krschau deleted the user/krschau/scroll-regions2 branch March 25, 2024 16:29
@krschau krschau removed the Needs-Second Pull request that needs another approval label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJohnson327 EricJohnson327 EricJohnson327 approved these changes

@guimafelipe guimafelipe guimafelipe approved these changes

@adrastogi adrastogi adrastogi approved these changes

@dhoehna dhoehna Awaiting requested review from dhoehna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev Home Scroll Regions are the wrong size
4 participants
@krschau @adrastogi @guimafelipe @EricJohnson327