Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root folder cleanup #2332

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Root folder cleanup #2332

merged 1 commit into from
Mar 4, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Feb 29, 2024

Summary of the pull request

Good to keep as few things in the root as possible. Also, create more structure to prepare for other things coming in.

  • Create an extensions directory and move CoreWidgetProvider and SampleExtension under it. More extensions will be coming in, so this is necessary to corral them.
  • Move sampleConfigurations directory under docs
  • In VS SolutionExplorer, move SampleTool and SamplelTool.UnitTest out of their own Samples directory and into the Tools directory

All changes should only be moves, except in .sln and .csproj files where paths are updated to reflect new locations.

Test and Build scripts should also move, will be done in a separate change.
I'd also potentially like to move settings/logging/telemetry under src. Please let me know if you have thoughts.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krschau, @RDMacLachlan, @denelon before merging please ensure that https://aka.ms/dsc.yaml is updated correspondingly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone can coordinate with me when the merge is being applied, I'll update the aka.ms link.

@krschau
Copy link
Collaborator Author

krschau commented Mar 1, 2024

Adding "do not merge" label so we can be sure to coordinate checking in and updating the aka.ms link.

@krschau krschau added the Do-Not-Merge Don't merge this in yet label Mar 1, 2024
@krschau krschau force-pushed the user/krschau/move branch from 6f12929 to c38e5ad Compare March 1, 2024 19:08
@denelon denelon merged commit 9e197e1 into main Mar 4, 2024
4 checks passed
@denelon
Copy link
Contributor

denelon commented Mar 4, 2024

@krschau I merged the PR and updated https://aka.ms/dsc.yaml.

@krschau krschau removed the Do-Not-Merge Don't merge this in yet label Mar 4, 2024
@krschau krschau added this to the Dev Home v0.12 milestone Mar 4, 2024
bbonaby pushed a commit that referenced this pull request Mar 4, 2024
@krschau krschau deleted the user/krschau/move branch March 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root folder cleanup
5 participants