Root folder cleanup #2332
Merged
Root folder cleanup #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
guimafelipe,
vineeththomasalex,
dkbennett,
EricJohnson327,
AmelBawa-msft and
bbonaby
There was a problem hiding this comment.
@krschau, @RDMacLachlan, @denelon before merging please ensure that https://aka.ms/dsc.yaml is updated correspondingly
There was a problem hiding this comment.
If someone can coordinate with me when the merge is being applied, I'll update the aka.ms link.
|
Adding "do not merge" label so we can be sure to coordinate checking in and updating the aka.ms link. |
vineeththomasalex
approved these changes
Mar 1, 2024
EricJohnson327
approved these changes
Mar 1, 2024
krschau
force-pushed
the
user/krschau/move
branch
from
6f12929 to
c38e5ad
Compare
|
@krschau I merged the PR and updated https://aka.ms/dsc.yaml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Good to keep as few things in the root as possible. Also, create more structure to prepare for other things coming in.
extensionsdirectory and move CoreWidgetProvider and SampleExtension under it. More extensions will be coming in, so this is necessary to corral them.sampleConfigurationsdirectory underdocsSamplesdirectory and into theToolsdirectoryAll changes should only be moves, except in .sln and .csproj files where paths are updated to reflect new locations.
Test and Build scripts should also move, will be done in a separate change.
I'd also potentially like to move settings/logging/telemetry under src. Please let me know if you have thoughts.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist