Update terms in review page

[florelis]

Summary of the pull request

Update the terms and agreements in the review page per legal review

References and relevant issues

Detailed description of the pull request / Additional comments

• Removed checkboxes to accept agreements and possibility of reboot
• Added new text approved by legal only if installing an application, and a more specific string if installing from the MS Store.
• Added a custom control to show a text block with an embedded hyperlink. This is intended to make it easier to localize the strings without having to concatenate multiple resource strings.

Validation steps performed

With app selected:

With app from the Store selected:

With no apps to install:

PR checklist

• Closes #xxx
• Tests added/passed
• Documentation updated

[florelis]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[bbonaby]

Nice! this would save me from having to do these in the future:

https://github.com/microsoft/devhome/blob/main/tools/SetupFlow/DevHome.SetupFlow/ViewModels/SummaryViewModel.cs#:~:text=var%20group%20%3D,RepoConfigTaskGroup%20repoTaskGroup)

https://github.com/microsoft/devhome/blob/main/tools/SetupFlow/DevHome.SetupFlow/Services/DevDriveManager.cs#:~:text=var%20group%20%3D,DevDriveTaskGroup%20driveTaskGroup)

[florelis]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[krschau]

@florelis Didn't see this yesterday. When we have some time (before open sourcing), I'd suggest renaming the HyperlinkTextBlock user control. It's useful for a very specific purpose, and we don't want anyone to come along thinking this is the normal way to put hyperlinks in TextBlocks. It should probably have a more specific name.

[florelis]

@florelis Didn't see this yesterday. When we have some time (before open sourcing), I'd suggest renaming the HyperlinkTextBlock user control. It's useful for a very specific purpose, and we don't want anyone to come along thinking this is the normal way to put hyperlinks in TextBlocks. It should probably have a more specific name.

Sure, we can rename it. What name would you suggest?

Also, what would be a better or more normal way to put hyperlinks in TextBlocks? I probably should change it to that one.

[krschau]

@florelis Sorry, I should have been more specific. What you do in HyperlinkTextBlock.xaml makes sense -- Runs and Hyperlinks to make up the TextBlock's contents. I'm just thinking of a total newbie coming in, not worrying about localization -- they don't need to create a custom control every time they want to put a hyperlink in a TextBlock.

Maybe something like "LocalizedTextBlockWithLink"?
Also, if you put it all on one line in the xaml markup (it's not that long) can you avoid using those comments, or does it still insert spaces?

But also, after poking around more, you're right! There does not seem to be a great way to solve this! I found a place in Settings where they deal with this, and they just make it three separate strings to translate. They must rely on the translators moving words around if the hyperlink part isn't at the end. Gets you out of needing a custom control, but more potential for translation error. I don't even see the translated versions in the source, so who knows. Your way is safer.
https://microsoft.visualstudio.com/DefaultCollection/OS/_git/0d54b6ef-7283-444f-847a-343728d58a4d?path=/shellcommon/shell/SystemSettings/desktop/HostApp/Resources/en-US/SystemSettings.resw&version=GBofficial/rs_we_adept&line=22785&lineEnd=22793&lineStartColumn=1&lineEndColumn=10&lineStyle=plain&_a=contents

I feel like I used to see this situation more. I wonder if they've leaned towards different designs because it is so awkward.

[florelis]

I'm just thinking of a total newbie coming in, not worrying about localization -- they don't need to create a custom control every time they want to put a hyperlink in a TextBlock.

Huh. I had never considered what could happen if a newbie used my code. Maybe I should be more careful.

Also, if you put it all on one line in the xaml markup (it's not that long) can you avoid using those comments, or does it still insert spaces?

I'm sure it would work putting it all in one line, but it seems harder to read and more likely to be messed with.

and they just make it three separate strings to translate. They must rely on the translators moving words around if the hyperlink part isn't at the end. Gets you out of needing a custom control, but more potential for translation error

Yeah... I was in a project that did that and it just felt mean to the translators lol
And translations already are awkward sometimes as is, without having to add in stuff like this.