Add Extensions page, update What's New page, change how extensions are installed #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page (#1449) Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
* Text trimmed if no more space available * Changing header from setup to set up * Removing unnecessary lines * Removing unnecessary lines pt. 2 * changing to word ellipsis --------- Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
krschau
requested review from
dhoehna,
guimafelipe,
florelis,
dkbennett,
cinnamon-msft,
EricJohnson327,
AmelBawa-msft and
ethanfangg
krschau
changed the title
tools/ExtensionLibrary/DevHome.ExtensionLibrary/Assets/extensionResult.json
Show resolved
Hide resolved
EricJohnson327
approved these changes
Sep 12, 2023
dhoehna
reviewed
Sep 12, 2023
dhoehna
reviewed
Sep 12, 2023
| // and finally throw them back in the normal sized cards collection. | ||
| public void SwitchToSmallerView() | ||
| { | ||
| if (BigSource.Count == 0) |
dhoehna
reviewed
Sep 12, 2023
| @@ -61,6 +61,25 @@ private async void OnLoaded(object sender, Microsoft.UI.Xaml.RoutedEventArgs e) | |||
|
|
|||
| ViewModel.AddCard(card); | |||
| } | |||
|
|
|||
| var whatsNewBigCards = BigFeaturesContainer.Resources | |||
| .Where((item) => item.Value.GetType() == typeof(WhatsNewCard)) | |||
There was a problem hiding this comment.
NIT: Extra () around item.
dhoehna
approved these changes
Sep 12, 2023
vineeththomasalex
approved these changes
Sep 12, 2023
tools/ExtensionLibrary/DevHome.ExtensionLibrary/ViewModels/InstalledPackageViewModel.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This is quite a large pull request, but all changes have been reviewed in smaller PRs that can be found in the list of commits below.
This change adds an "Extension Library" where users can install Dev Home extensions from the store. For now, there is only one extension, so we have a static file with the list that we can edit as the extensions grow, and eventually query directly from the store.
This also adds Extensions the "What's new" page.
We also no longer install the Dev Home GitHub Extension automatically.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist