Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extensions page, update What's New page, change how extensions are installed #1529

Merged
merged 10 commits into from
Sep 12, 2023

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Sep 12, 2023

Summary of the pull request

This is quite a large pull request, but all changes have been reviewed in smaller PRs that can be found in the list of commits below.

This change adds an "Extension Library" where users can install Dev Home extensions from the store. For now, there is only one extension, so we have a static file with the list that we can edit as the extensions grow, and eventually query directly from the store.

This also adds Extensions the "What's new" page.

We also no longer install the Dev Home GitHub Extension automatically.

image
image

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

krschau and others added 10 commits September 12, 2023 10:18
…page (#1449)

Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
* Text trimmed if no more space available

* Changing header from setup to set up

* Removing unnecessary lines

* Removing unnecessary lines pt. 2

* changing to word ellipsis

---------

Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
@krschau krschau added this to the Dev Home v0.5 milestone Sep 12, 2023
@krschau krschau removed this from the Dev Home v0.5 milestone Sep 12, 2023
@krschau krschau changed the title Add Extensions page, don't automatically install any extensions Add Extensions page, update What's New page, change how extensions are installed Sep 12, 2023
// and finally throw them back in the normal sized cards collection.
public void SwitchToSmallerView()
{
if (BigSource.Count == 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: !BigSource.Any()

@@ -61,6 +61,25 @@ private async void OnLoaded(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)

ViewModel.AddCard(card);
}

var whatsNewBigCards = BigFeaturesContainer.Resources
.Where((item) => item.Value.GetType() == typeof(WhatsNewCard))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Extra () around item.

@krschau krschau merged commit f4b346d into main Sep 12, 2023
@krschau krschau deleted the feature/extensions branch September 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marketplace & Library for extensions
5 participants