Fix attach to process on arm64 Mac. (#1917)

* Before this change it was not possible to attach to a process on arm64 mac.

The primary issue was that we weren't building the attach.dylib for all targets; but even once we did that we had to ensure that we were exiting successfully after injecting into the process.

We pulled in the compile changes from JetBrains/intellij-community@2e7109f

Co-authored-by: @artemmukhin <Artem.Mukhin@jetbrains.com>
Co-authored-by: Cole Miller <cole@zed.dev>

* Use g++ on macOS (with -D_FORTIFY_SOURCE=2)

---------

Co-authored-by: @artemmukhin <Artem.Mukhin@jetbrains.com>
Co-authored-by: Cole Miller <cole@zed.dev>

Author: 3 people

build_attach_binaries.py

@@ -1,6 +1,7 @@
 # This script is used for building the pydevd binaries
 import argparse
 import os
+import platform
 
 def build_pydevd_binaries(force: bool):
     os.environ["PYDEVD_USE_CYTHON"] = "yes"
@@ -20,16 +21,19 @@ def build_pydevd_binaries(force: bool):
 
     # Run the appropriate batch script to build the binaries if necessary.
     pydevd_attach_to_process_root = os.path.join(pydevd_root, "pydevd_attach_to_process")
-    if os.name == "nt":
+    if platform.system() == "Windows":
         if not os.path.exists(os.path.join(pydevd_attach_to_process_root, "attach_amd64.dll")) or force:
             os.system(os.path.join(pydevd_attach_to_process_root, "windows", "compile_windows.bat"))
-    elif os.name == "posix":
+    elif platform.system() == "Linux":
         if not os.path.exists(os.path.join(pydevd_attach_to_process_root, "attach_linux_amd64.so")) or force:
             os.system(os.path.join(pydevd_attach_to_process_root, "linux_and_mac", "compile_linux.sh"))
-    else:
-        if not os.path.exists(os.path.join(pydevd_attach_to_process_root, "attach_x86_64.dylib")) or force:
+    elif platform.system() == "Darwin":
+        if not os.path.exists(os.path.join(pydevd_attach_to_process_root, "attach.dylib")) or force:
             os.system(os.path.join(pydevd_attach_to_process_root, "linux_and_mac", "compile_mac.sh"))
-    
+    else:
+        print("unsupported platform.system(): {}".format(platform.system()))
+        exit(1)
+
 
 if __name__ == "__main__":
     arg_parser = argparse.ArgumentParser(description="Build the pydevd binaries.")

src/debugpy/_vendored/pydevd/pydevd_attach_to_process/add_code_to_python_process.py

@@ -183,7 +183,7 @@ def get_target_filename(is_target_process_64=None, prefix=None, extension=None):
         print("Unable to attach to process in platform: %s", sys.platform)
         return None
 
-    if arch.lower() not in ("amd64", "x86", "x86_64", "i386", "x86"):
+    if arch.lower() not in ("arm64", "amd64", "x86", "x86_64", "i386", "x86"):
         # We don't support this processor by default. Still, let's support the case where the
         # user manually compiled it himself with some heuristics.
         #
@@ -237,8 +237,11 @@ def get_target_filename(is_target_process_64=None, prefix=None, extension=None):
 
         if not prefix:
             # Default is looking for the attach_ / attach_linux
-            if IS_WINDOWS or IS_MAC:  # just the extension changes
+            if IS_WINDOWS:  # just the extension changes
                 prefix = "attach_"
+            elif IS_MAC:
+                prefix = "attach"
+                suffix = ""
             elif IS_LINUX:
                 prefix = "attach_linux_"  # historically it has a different name
             else:
@@ -525,7 +528,7 @@ def run_python_code_mac(pid, python_code, connect_debugger_tracing=False, show_d
     cmd.extend(
         [
             "-o 'process detach'",
-            "-o 'script import os; os._exit(1)'",
+            "-o 'script import os; os._exit(0)'",
         ]
     )
 

src/debugpy/_vendored/pydevd/pydevd_attach_to_process/linux_and_mac/compile_mac.sh

@@ -1,4 +1,14 @@
+#!/bin/bash
 set -e
 SRC="$(dirname "$0")/.."
-g++ -fPIC -D_REENTRANT -std=c++11 -D_FORTIFY_SOURCE=2 -arch x86_64 -c $SRC/linux_and_mac/attach.cpp -o $SRC/attach_x86_64.o
-g++ -dynamiclib -nostartfiles -arch x86_64 -lc $SRC/attach_x86_64.o -o $SRC/attach_x86_64.dylib
+
+g++ -fPIC -D_REENTRANT -std=c++11 -D_FORTIFY_SOURCE=2 -arch arm64 -c -o "$SRC/attach_arm64.o" "$SRC/linux_and_mac/attach.cpp"
+g++ -dynamiclib -nostartfiles -arch arm64 -o "$SRC/attach_arm64.dylib" "$SRC/attach_arm64.o" -lc
+rm "$SRC/attach_arm64.o"
+
+g++ -fPIC -D_REENTRANT -std=c++11 -D_FORTIFY_SOURCE=2 -arch x86_64 -c -o "$SRC/attach_x86_64.o" "$SRC/linux_and_mac/attach.cpp"
+g++ -dynamiclib -nostartfiles -arch x86_64 -o "$SRC/attach_x86_64.dylib" "$SRC/attach_x86_64.o" -lc
+rm "$SRC/attach_x86_64.o"
+
+lipo -create "$SRC/attach_arm64.dylib" "$SRC/attach_x86_64.dylib" -output "$SRC/attach.dylib"
+rm "$SRC/attach_arm64.dylib" "$SRC/attach_x86_64.dylib"

src/debugpy/_vendored/pydevd/pydevd_tracing.py

@@ -201,7 +201,7 @@ def get_python_helper_lib_filename():
         pydev_log.info("Unable to set trace to all threads in platform: %s", sys.platform)
         return None
 
-    if arch.lower() not in ("amd64", "x86", "x86_64", "i386", "x86"):
+    if arch.lower() not in ("arm64", "amd64", "x86", "x86_64", "i386", "x86"):
         # We don't support this processor by default. Still, let's support the case where the
         # user manually compiled it himself with some heuristics.
         #
@@ -251,7 +251,8 @@ def get_python_helper_lib_filename():
             suffix = suffix_32
 
         if IS_WINDOWS or IS_MAC:  # just the extension changes
-            prefix = "attach_"
+            prefix = "attach"
+            suffix = ""
         elif IS_LINUX:  #
             prefix = "attach_linux_"  # historically it has a different name
         else: