Build failure after pull request #892

[LocutusOfBorg]

@chris0x44 @BillyONeal
Lets discuss the build regression in a new issue.
This commit makes the Debian/Ubuntu builds fail...
http://debomatic-amd64.debian.net/distribution#unstable/cpprest/2.10.7-1/buildlog

any idea?

cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/Release/src && /usr/bin/c++  -DCPPREST_EXCLUDE_BROTLI=1 -DCPPREST_FORCE_HTTP_CLIENT_ASIO -DCPPREST_FORCE_HTTP_LISTENER_ASIO -DCPPREST_NO_SSL_LEAK_SUPPRESS -Dcpprest_EXPORTS -I/<<PKGBUILDDIR>>/Release/include -I/<<PKGBUILDDIR>>/Release/src/pch  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++11 -fno-strict-aliasing -fPIC   -Werror -pedantic -Wall -Wextra -Wunused-parameter -Wcast-align -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls -Wunreachable-code -o CMakeFiles/cpprest.dir/websockets/client/ws_msg.cpp.o -c /<<PKGBUILDDIR>>/Release/src/websockets/client/ws_msg.cpp
/<<PKGBUILDDIR>>/Release/src/utilities/asyncrt_utils.cpp: In function 'size_t utility::count_utf8_to_utf16(const string&)':
/<<PKGBUILDDIR>>/Release/src/utilities/asyncrt_utils.cpp:359:76: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     auto sData = reinterpret_cast<const UtilCharInternal_t* const>(s.data());
                                                                            ^
/<<PKGBUILDDIR>>/Release/src/utilities/asyncrt_utils.cpp: In function 'utf16string utility::conversions::utf8_to_utf16(const string&)':
/<<PKGBUILDDIR>>/Release/src/utilities/asyncrt_utils.cpp:444:78: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     auto srcData = reinterpret_cast<const UtilCharInternal_t* const>(s.data());
                                                                              ^
[ 13%] Building CXX object Release/src/CMakeFiles/cpprest.dir/websockets/client/ws_client.cpp.o
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/Release/src && /usr/bin/c++  -DCPPREST_EXCLUDE_BROTLI=1 -DCPPREST_FORCE_HTTP_CLIENT_ASIO -DCPPREST_FORCE_HTTP_LISTENER_ASIO -DCPPREST_NO_SSL_LEAK_SUPPRESS -Dcpprest_EXPORTS -I/<<PKGBUILDDIR>>/Release/include -I/<<PKGBUILDDIR>>/Release/src/pch  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++11 -fno-strict-aliasing -fPIC   -Werror -pedantic -Wall -Wextra -Wunused-parameter -Wcast-align -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls -Wunreachable-code -o CMakeFiles/cpprest.dir/websockets/client/ws_client.cpp.o -c /<<PKGBUILDDIR>>/Release/src/websockets/client/ws_client.cpp

[chris0x44]

Oh, I see the problem. Trying to make the pointer itself const via reinterpret_cast causes the warning. The reason is that the pointer is copied therefore "loses" its constness, which is why -Werror=ignored-qualifiers complain. ( Found a nice explanation: https://www.oreilly.com/library/view/effective-modern-c/9781491908419/ch01.html#idm140645364687248 )

So it should either be
auto srcData = reinterpret_cast<const UtilCharInternal_t*>(s.data());
or
auto const srcData = reinterpret_cast<const UtilCharInternal_t*>(s.data());

I'd go with the latter with the fix as that will achieve the intention of the original code.

[BillyONeal]

@LocutusOfBorg Any idea why the Ubuntu validation build on that PR is passing if this broke for you?

[chris0x44]

@BillyONeal Is there anything to consider regarding the fix or shall I just create a new PR?

[LocutusOfBorg]

@BillyONeal my opinion is that gcc-8 is more picky wrt bad casts... or the new glibc, or the new binutils or something different in the toolchain. Debian unstable has really higher versions compared to ubuntu trusty or xenial (or even bionic).

this patch fixes my issue:

Index: cpprest/Release/src/utilities/asyncrt_utils.cpp
===================================================================
--- cpprest.orig/Release/src/utilities/asyncrt_utils.cpp
+++ cpprest/Release/src/utilities/asyncrt_utils.cpp
@@ -356,7 +356,7 @@
 inline size_t count_utf8_to_utf16(const std::string& s)
 {
     const size_t sSize = s.size();
-    auto sData = reinterpret_cast<const UtilCharInternal_t* const>(s.data());
+    auto const sData = reinterpret_cast<const UtilCharInternal_t*>(s.data());
     size_t result{ sSize };
 
     for (size_t index = 0; index < sSize;)
@@ -441,7 +441,7 @@
 {
     // Save repeated heap allocations, use the length of resulting sequence.
     const size_t srcSize = s.size();
-    auto srcData = reinterpret_cast<const UtilCharInternal_t* const>(s.data());
+    auto const srcData = reinterpret_cast<const UtilCharInternal_t*>(s.data());
     utf16string dest(count_utf8_to_utf16(s), L'\0');
     utf16string::value_type* const destData = &dest[0];
     size_t destIndex = 0;

[LocutusOfBorg]

oh you already did commit it... well thanks for the quick fix!

[chris0x44]

Sure thing. :) Sorry for breaking the build.

[LocutusOfBorg]

thanks for fixing it! no problem, build breaks, what matters is to fix it :)

[BillyONeal]

@LocutusOfBorg Can you send us how what you're doing differs from https://github.com/Microsoft/cpprestsdk/blob/1aeab07bd129e92bbef572fd18db648158d283b1/azure-pipelines.yml#L132 ? Is it just running on Debian Unstable or is there something else?

Basically I want to make sure that before we bump a release number that we've tried this and fixed any problems (even if we can't get Azure Pipelines to do the validation build for us).

Thanks!

[LocutusOfBorg]

@BillyONeal you can diff the builds with mine, but I use default flags, and hardening stuff.
https://sources.debian.org/src/cpprest/2.10.7-1/debian/rules/

the main different is really that we introduced lots of new checks in 18.04 wrt 16.04, and gcc-8 became more and more picky with "dubious" pointers. Migrating to 18.04 will probably allow you to drop some ppa in that script, and to have more strict builds. But I don't know if azure does support 18.04 already
(in case having a new test case on 18.04 will probably be enough to trigger such issues)

[LocutusOfBorg]

toolchain:

Package versions: adduser_3.118 apt_1.7.0 autoconf_2.69-11 automake_1:1.16.1-4 autopoint_0.19.8.1-8 autotools-dev_20180224.1 base-files_10.1 base-passwd_3.5.45 bash_4.4.18-3.1 binutils_2.31.1-7 binutils-common_2.31.1-7 binutils-x86-64-linux-gnu_2.31.1-7 bsdmainutils_11.1.2+b1 bsdutils_1:2.32.1-0.1 build-essential_12.5 bzip2_1.0.6-9 ca-certificates_20180409 cmake_3.12.3-3 cmake-data_3.12.3-3 coreutils_8.30-1 cpp_4:8.2.0-2 cpp-8_8.2.0-9 dash_0.5.10.2-1 debconf_1.5.69 debhelper_11.5.1 debian-archive-keyring_2018.1 debianutils_4.8.6 dh-autoreconf_19 dh-strip-nondeterminism_0.043-2 diffutils_1:3.6-1 dpkg_1.19.2 dpkg-dev_1.19.2 dwz_0.12-2 e2fsprogs_1.44.4-2 fakeroot_1.23-1 fdisk_2.32.1-0.1 file_1:5.34-2 findutils_4.6.0+git+20181018-1 g++_4:8.2.0-2 g++-8_8.2.0-9 gcc_4:8.2.0-2 gcc-8_8.2.0-9 gcc-8-base_8.2.0-9 gettext_0.19.8.1-8 gettext-base_0.19.8.1-8 gir1.2-glib-2.0_1.58.0-1 gir1.2-harfbuzz-0.0_1.9.0-1 gpgv_2.2.10-3 grep_3.1-2 groff-base_1.22.3-10 gzip_1.9-2.1 hostname_3.21 icu-devtools_60.2-6 init-system-helpers_1.55 intltool-debian_0.35.0+20060710.4 libacl1_2.2.52-3+b1 libapt-pkg5.0_1.7.0 libarchive-zip-perl_1.64-1 libarchive13_3.2.2-5 libasan5_8.2.0-9 libatomic1_8.2.0-9 libattr1_1:2.4.47-2+b2 libaudit-common_1:2.8.4-2 libaudit1_1:2.8.4-2 libbinutils_2.31.1-7 libblkid1_2.32.1-0.1 libboost-atomic-dev_1.62.0.1 libboost-atomic1.62-dev_1.62.0+dfsg-10 libboost-atomic1.62.0_1.62.0+dfsg-10 libboost-chrono-dev_1.62.0.1 libboost-chrono1.62-dev_1.62.0+dfsg-10 libboost-chrono1.62.0_1.62.0+dfsg-10 libboost-date-time1.62-dev_1.62.0+dfsg-10 libboost-date-time1.62.0_1.62.0+dfsg-10 libboost-filesystem-dev_1.62.0.1 libboost-filesystem1.62-dev_1.62.0+dfsg-10 libboost-filesystem1.62.0_1.62.0+dfsg-10 libboost-random-dev_1.62.0.1 libboost-random1.62-dev_1.62.0+dfsg-10 libboost-random1.62.0_1.62.0+dfsg-10 libboost-regex-dev_1.62.0.1 libboost-regex1.62-dev_1.62.0+dfsg-10 libboost-regex1.62.0_1.62.0+dfsg-10 libboost-serialization1.62-dev_1.62.0+dfsg-10 libboost-serialization1.62.0_1.62.0+dfsg-10 libboost-system-dev_1.62.0.1 libboost-system1.62-dev_1.62.0+dfsg-10 libboost-system1.62.0_1.62.0+dfsg-10 libboost-thread-dev_1.62.0.1 libboost-thread1.62-dev_1.62.0+dfsg-10 libboost-thread1.62.0_1.62.0+dfsg-10 libboost1.62-dev_1.62.0+dfsg-10 libbrotli-dev_1.0.7-1 libbrotli1_1.0.7-1 libbsd0_0.9.1-1 libbz2-1.0_1.0.6-9 libc-bin_2.27-8 libc-dev-bin_2.27-8 libc6_2.27-8 libc6-dev_2.27-8 libcap-ng0_0.7.9-1 libcc1-0_8.2.0-9 libcom-err2_1.44.4-2 libcroco3_0.6.12-2 libcurl4_7.62.0-1 libdb5.3_5.3.28+dfsg1-0.2 libdebconfclient0_0.245 libdpkg-perl_1.19.2 libelf1_0.170-0.5 libexpat1_2.2.6-1 libext2fs2_1.44.4-2 libfakeroot_1.23-1 libfdisk1_2.32.1-0.1 libffi6_3.2.1-8 libfile-stripnondeterminism-perl_0.043-2 libfreetype6_2.8.1-2 libgcc-8-dev_8.2.0-9 libgcc1_1:8.2.0-9 libgcrypt20_1.8.4-3 libgdbm-compat4_1.18.1-1 libgdbm6_1.18.1-1 libgirepository-1.0-1_1.58.0-1 libglib2.0-0_2.58.1-2 libglib2.0-bin_2.58.1-2 libglib2.0-data_2.58.1-2 libglib2.0-dev_2.58.1-2 libglib2.0-dev-bin_2.58.1-2 libgmp10_2:6.1.2+dfsg-3 libgnutls30_3.5.19-1+b1 libgomp1_8.2.0-9 libgpg-error0_1.32-3 libgraphite2-3_1.3.12-1 libgraphite2-dev_1.3.12-1 libgssapi-krb5-2_1.16.1-1 libharfbuzz-dev_1.9.0-1 libharfbuzz-gobject0_1.9.0-1 libharfbuzz-icu0_1.9.0-1 libharfbuzz0b_1.9.0-1 libhogweed4_3.4-1 libicu-dev_60.2-6 libicu-le-hb-dev_1.0.3+git161113-5 libicu-le-hb0_1.0.3+git161113-5 libicu60_60.2-6 libidn2-0_2.0.5-1 libisl19_0.20-2 libitm1_8.2.0-9 libjsoncpp1_1.7.4-3 libk5crypto3_1.16.1-1 libkeyutils1_1.5.9-9.3 libkrb5-3_1.16.1-1 libkrb5support0_1.16.1-1 libldap-2.4-2_2.4.46+dfsg-5+b1 libldap-common_2.4.46+dfsg-5 liblsan0_8.2.0-9 liblz4-1_1.8.2-1 liblzma5_5.2.2-1.3 liblzo2-2_2.10-0.1 libmagic-mgc_1:5.34-2 libmagic1_1:5.34-2 libmount1_2.32.1-0.1 libmpc3_1.1.0-1 libmpdec2_2.4.2-2 libmpfr6_4.0.1-1 libmpx2_8.2.0-9 libncurses6_6.1+20181013-1 libncursesw6_6.1+20181013-1 libnettle6_3.4-1 libnghttp2-14_1.34.0-1 libp11-kit0_0.23.14-2 libpam-modules_1.1.8-3.8 libpam-modules-bin_1.1.8-3.8 libpam-runtime_1.1.8-3.8 libpam0g_1.1.8-3.8 libpcre16-3_2:8.39-11 libpcre3_2:8.39-11 libpcre3-dev_2:8.39-11 libpcre32-3_2:8.39-11 libpcrecpp0v5_2:8.39-11 libperl5.28_5.28.0-3 libpipeline1_1.5.0-2 libpng16-16_1.6.34-2 libprocps7_2:3.3.15-2 libpsl5_0.20.2-2 libpython3-stdlib_3.6.7-1 libpython3.6-minimal_3.6.7-1 libpython3.6-stdlib_3.6.7-1 libquadmath0_8.2.0-9 libreadline7_7.0-5 librhash0_1.3.6-3 librtmp1_2.4+20151223.gitfa8646d.1-2 libsasl2-2_2.1.27~rc8-1 libsasl2-modules-db_2.1.27~rc8-1 libseccomp2_2.3.3-3 libselinux1_2.8-1+b1 libsemanage-common_2.8-1 libsemanage1_2.8-1+b1 libsepol1_2.8-1 libsigsegv2_2.12-2 libsmartcols1_2.32.1-0.1 libsqlite3-0_3.25.2-1 libss2_1.44.4-2 libssh2-1_1.8.0-2 libssl-dev_1.1.1-2 libssl1.1_1.1.1-2 libstdc++-8-dev_8.2.0-9 libstdc++6_8.2.0-9 libsystemd0_239-11 libtasn1-6_4.13-3 libtinfo6_6.1+20181013-1 libtool_2.4.6-6 libtsan0_8.2.0-9 libubsan1_8.2.0-9 libudev1_239-11 libunistring2_0.9.10-1 libuuid1_2.32.1-0.1 libuv1_1.23.2-1 libwebsocketpp-dev_0.8.1-1 libxml2_2.9.4+dfsg1-7+b1 libzstd1_1.3.5+dfsg-1 linux-libc-dev_4.18.10-2+b1 login_1:4.5-1.1 lsb-base_9.20170808 m4_1.4.18-1 make_4.2.1-1.2 man-db_2.8.4-2+b1 mawk_1.3.3-17+b3 mime-support_3.61 mount_2.32.1-0.1 ncurses-base_6.1+20181013-1 ncurses-bin_6.1+20181013-1 openssl_1.1.1-2 passwd_1:4.5-1.1 patch_2.7.6-3 perl_5.28.0-3 perl-base_5.28.0-3 perl-modules-5.28_5.28.0-3 pkg-config_0.29-4+b1 po-debconf_1.0.20 policyrcd-script-zg2_0.1-3 procps_2:3.3.15-2 python3_3.6.7-1 python3-distutils_3.7.1-1 python3-lib2to3_3.7.1-1 python3-minimal_3.6.7-1 python3.6_3.6.7-1 python3.6-minimal_3.6.7-1 readline-common_7.0-5 sbuild-build-depends-core-dummy_0.invalid.0 sbuild-build-depends-cpprest-dummy_0.invalid.0 sed_4.5-2 sysvinit-utils_2.88dsf-59.11 tar_1.30+dfsg-2 tzdata_2018g-1 util-linux_2.32.1-0.1 xz-utils_5.2.2-1.3 zlib1g_1:1.2.11.dfsg-1 zlib1g-dev_1:1.2.11.dfsg-1

my configure script:

dh_auto_configure -- -DCPPREST_EXPORT_DIR=cmake -DCPPREST_EXCLUDE_BROTLI=OFF
	cd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON "-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu -DCPPREST_EXPORT_DIR=cmake -DCPPREST_EXCLUDE_BROTLI=OFF ..

example of flags used:

cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/Release/src && /usr/bin/c++  -DCPPREST_FORCE_HTTP_CLIENT_ASIO -DCPPREST_FORCE_HTTP_LISTENER_ASIO -DCPPREST_NO_SSL_LEAK_SUPPRESS -Dcpprest_EXPORTS -I/<<PKGBUILDDIR>>/Release/include -I/<<PKGBUILDDIR>>/Release/src/pch  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++11 -fno-strict-aliasing -fPIC   -Werror -pedantic -Wall -Wextra -Wunused-parameter -Wcast-align -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls -Wunreachable-code -o CMakeFiles/cpprest.dir/http/client/http_client_msg.cpp.o -c /<<PKGBUILDDIR>>/Release/src/http/client/http_client_msg.cpp

[LocutusOfBorg]

https://buildd.debian.org/status/fetch.php?pkg=cpprest&arch=amd64&ver=2.10.7-1&stamp=1541422575&raw=0