Don't enable certificate revocation check if client config has validate certificates set to false

Zeke Snider · Zeke Snider · commit 9743f2bb0805 · 2018-02-02T16:50:39.000-08:00
diff --git a/Release/src/http/client/http_client_winhttp.cpp b/Release/src/http/client/http_client_winhttp.cpp
@@ -639,7 +639,7 @@ class winhttp_client : public _http_client_communicator
         }
 
         // Enable the certificate revocation check
-        if (m_secure)
+        if (m_secure && client_config().validate_certificates())
         {
             DWORD dwEnableSSLRevocOpt = WINHTTP_ENABLE_SSL_REVOCATION;
             if (!WinHttpSetOption(winhttp_context->m_request_handle, WINHTTP_OPTION_ENABLE_FEATURE, &dwEnableSSLRevocOpt, sizeof(dwEnableSSLRevocOpt)))

Original file line number	Diff line number	Diff line change
`@@ -639,7 +639,7 @@ class winhttp_client : public _http_client_communicator`
`639`	`639`	`}`
`640`	`640`
`641`	`641`	`// Enable the certificate revocation check`
`642`		`- if (m_secure)`
	`642`	`+ if (m_secure && client_config().validate_certificates())`
`643`	`643`	`{`
`644`	`644`	`DWORD dwEnableSSLRevocOpt = WINHTTP_ENABLE_SSL_REVOCATION;`
`645`	`645`	`if (!WinHttpSetOption(winhttp_context->m_request_handle, WINHTTP_OPTION_ENABLE_FEATURE, &dwEnableSSLRevocOpt, sizeof(dwEnableSSLRevocOpt)))`