Skip to content

Crash during Upload on OfflineStorageSQLite #1157

Open

Description

Describe your environment.
Reproduced on Windows 11, Solutions/version.txt is 3.6.999.1

Steps to reproduce.
This is a race condition that is a bit tricky to reproduce and as consequence not easy.

  • Create an object that holds an instance of the logmanager (Do not use the singleton/global instance) and during the destructor calls UploadNow()
  • Create a shared pointer instance of a that class
  • Create a thread that gets an instance of that ptr (we should have the atomic counter value to two).
  • Ensure that thread outlives Main.

We need to reproduce the following.

  • Main finishes. (Our object should have atomic counter to 1)
  • Singletons clean up process starts, destroying any 1ds internal shaningans
  • Thread finishes and sets the object count to 0 calling its destructor.
  • Destructor calls logmanager->Uploadnow()
  • Crashes

What is the expected behavior?
Internal constructs of 1ds should be bound to lifecycle of the loggers not the process. The process should control the lifecycle of the logger.

What is the actual behavior?
Process crashes at shutdown

Additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions