This repository was archived by the owner on May 20, 2025. It is now read-only.
Disable api calls #851
Merged
Disable api calls #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've built and tested this PR on my machine. Everything seems fine. |
IlyaBausovAkvelon
approved these changes
Dec 5, 2024
DordeDimitrijev
requested review from
DmitriyKirakosyan and
IlyaBausovAkvelon
DmitriyKirakosyan
previously approved these changes
Dec 10, 2024
lucen-ms
reviewed
Dec 13, 2024
| @@ -80,7 +82,21 @@ export class AcquisitionManager { | |||
| this._ignoreAppVersion = configuration.ignoreAppVersion; | |||
| } | |||
|
|
|||
| private isRecoverable = (statusCode: number): boolean => statusCode >= 500 || statusCode === 408 || statusCode === 429; | |||
There was a problem hiding this comment.
You check this when response code is not 200 - what about other 2xx or 3xx responses - are they recoverable or not?
DmitriyKirakosyan
approved these changes
Dec 16, 2024
lucen-ms
approved these changes
Dec 16, 2024
This was referenced Dec 16, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented feature for stopping api calls from being sent after unsuccessful response. This behavior is aligned with other appcenter SDKs. Disabling of api calls occurs only per session after first failed request.
Related PRs or issues
AB#107980