Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI app project structure #99

Merged
merged 10 commits into from
May 20, 2019
Merged

Conversation

ianphil
Copy link
Contributor

@ianphil ianphil commented May 13, 2019

All Submissions:


  • [YES] Have you followed the guidelines in our Contributing document?
  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.
  • [YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?


Introducing new behavior

What is the new behavior?


Currently this only contains the start of the project structure for the CLI, a test that is only a pattern to follow once it's no just plumbing code, Makefile, and Readme. From a terminal, cd into the cli folder and run:

make deps
make build
make run
make test

We are currently only using go-cobra and go-testing packages just to get something committed.

To use the cli:

make build

Look at help:

./cobalt -h

./cobalt <cmd> -h

Look at cmds:

./cobalt setup --template "cobalt/azure-simple"

cmds should only print command issued to screen

Does this introduce a breaking change?


  • [No]

Any relevant logs, error output, etc?


  • [No]

Other information


  • [NA]

@ianphil ianphil requested a review from erikschlegel as a code owner May 13, 2019 20:56
@ianphil ianphil changed the title CLI app project structure WIP: CLI app project structure May 14, 2019
@ianphil ianphil changed the title WIP: CLI app project structure CLI app project structure May 14, 2019
@ianphil ianphil force-pushed the iphilpot/cli-93 branch from 6cb68c4 to 970d23e Compare May 15, 2019 13:55
@ianphil ianphil self-assigned this May 16, 2019
@ianphil ianphil added effort - small 1 day effort enhancement New feature or request labels May 16, 2019
@ianphil ianphil added this to the Sprint 4 milestone May 16, 2019
@ianphil ianphil requested a review from James-Nance May 16, 2019 15:46
cli/README.md Show resolved Hide resolved
cli/README.md Show resolved Hide resolved
cli/README.md Show resolved Hide resolved
cli/cmd/root.go Show resolved Hide resolved
Copy link
Contributor

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just included some minor nits, but this looks great. Stoked to see efforts around the CLI get kicked off which will bring much needed improvement to dev experience for cobalt.

cli/Gopkg.toml Outdated Show resolved Hide resolved
cli/Makefile Outdated Show resolved Hide resolved
cli/Makefile Show resolved Hide resolved
cli/cmd/root.go Outdated Show resolved Hide resolved
@nmiodice
Copy link

FYI I believe I fixed the build issue you are running into, which is only rearing its ugly head now that we are running fork PRs.

For context, here is what I changed: https://github.com/microsoft/cobalt/pull/105/files#diff-5741e0c550b7539f2b44e35ba19fc8be

erikschlegel
erikschlegel previously approved these changes May 17, 2019
@ianphil ianphil merged commit bca91d0 into microsoft:master May 20, 2019
@ianphil ianphil deleted the iphilpot/cli-93 branch May 20, 2019 11:20
manojvazirani pushed a commit to manojvazirani/entref-appservice-containers that referenced this pull request Jul 16, 2020
* # This is a combination of 99 commits.
# This is the 1st commit message:

Adding docker test base image

# This is the commit message microsoft#2:

Adding test files

# This is the commit message microsoft#3:

testing

# This is the commit message microsoft#4:

Added folder

# This is the commit message microsoft#5:

Added folder

# This is the commit message microsoft#6:

Azure Devops CI Build Pipeline (microsoft#67)

* Adding azure devops build pipeline

* Adding README

* Adding azure build badge

# This is the commit message microsoft#7:

saving latest tests

# This is the commit message microsoft#8:

Adding docker test base image (microsoft#68)


# This is the commit message microsoft#9:

EOD checkin

# This is the commit message microsoft#10:

posting latest

# This is the commit message microsoft#11:

eod commits

# This is the commit message microsoft#12:

eod commit

# This is the commit message microsoft#13:

refactored test directory structure

# This is the commit message microsoft#14:

Refactored build

# This is the commit message microsoft#15:

Adding hello world azure simple app

# This is the commit message microsoft#16:

Adding hello world azure simple app

# This is the commit message microsoft#17:

refactoring test harness

# This is the commit message microsoft#18:

refactoring test harness

# This is the commit message microsoft#19:

checking latest

# This is the commit message microsoft#20:

committing latest

# This is the commit message microsoft#21:

checking in latest changes

# This is the commit message microsoft#22:

Checking in latest progress

# This is the commit message microsoft#23:

applying final touches before PR submission

# This is the commit message microsoft#24:

updating azure keyvault secret names

# This is the commit message microsoft#25:

Checking in latest progress

# This is the commit message microsoft#26:

pushing latest pipeline definition

# This is the commit message microsoft#27:

updating build pipeline variable format

# This is the commit message microsoft#28:

updating build pipeline variable format

# This is the commit message microsoft#29:

cleaning up build variables

# This is the commit message microsoft#30:

adding minor changes to azure build pipeline

# This is the commit message microsoft#31:

updating azure keyvault secret names

# This is the commit message microsoft#32:

updating azure keyvault secret names

# This is the commit message microsoft#33:

fixing docker login azdo step

# This is the commit message microsoft#34:

fixing docker login azdo step

# This is the commit message microsoft#35:

fixing docker login azdo step

# This is the commit message microsoft#36:

fixing docker login azdo step

# This is the commit message microsoft#37:

updating build pipeline variables

# This is the commit message microsoft#38:

updating build pipeline variables

# This is the commit message microsoft#39:

updating build pipeline variables

# This is the commit message microsoft#40:

updating build pipeline variables

# This is the commit message microsoft#41:

updating build pipeline variables

# This is the commit message microsoft#42:

updating build pipeline variables

# This is the commit message microsoft#43:

applying fix to git diff script

# This is the commit message microsoft#44:

applying fix to git diff script

# This is the commit message microsoft#45:

applying fix to git diff script

# This is the commit message microsoft#46:

applying fix to git diff script

# This is the commit message microsoft#47:

applying fix to git diff script

# This is the commit message microsoft#48:

resolving pipeline bug

# This is the commit message microsoft#49:

fixing build error

# This is the commit message microsoft#50:

fixing build error

# This is the commit message microsoft#51:

fixing build error

# This is the commit message microsoft#52:

fixing build error

# This is the commit message microsoft#53:

fixing build error

# This is the commit message microsoft#54:

fixing build error

# This is the commit message microsoft#55:

fixing build error

# This is the commit message microsoft#56:

fixing build error

# This is the commit message microsoft#57:

fixing build error

# This is the commit message microsoft#58:

fixing build error

# This is the commit message microsoft#59:

fixing build error

# This is the commit message microsoft#60:

fixing build error

# This is the commit message microsoft#61:

fixing build error

# This is the commit message microsoft#62:

fixing build error

# This is the commit message microsoft#63:

fixing build error

# This is the commit message microsoft#64:

fixing build error

# This is the commit message microsoft#65:

fixing build error

# This is the commit message microsoft#66:

fixing build error

# This is the commit message microsoft#67:

fixing build error

# This is the commit message microsoft#68:

fixing build error

# This is the commit message microsoft#69:

fixing build error

# This is the commit message microsoft#70:

fixing build error

# This is the commit message microsoft#71:

fixing build error

# This is the commit message microsoft#72:

fixing build error

# This is the commit message microsoft#73:

trying acr fix

# This is the commit message microsoft#74:

latest changes

# This is the commit message microsoft#75:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#76:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#77:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#78:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#79:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#80:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#81:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#82:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#83:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#84:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#85:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#86:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#87:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#88:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#89:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#90:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#91:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#92:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#93:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#94:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#95:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#96:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#97:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#98:

final commit including resource name randomization

# This is the commit message microsoft#99:

Add provider to configure az infra for Terraform

* resolving merge conflicts for squash

Updated documentation based on review comments

Integrate review comments for documentation.

Add usage example for each of the providers

Adding environment template descriptions

removing go version var from azdo pipeline as it's unused

removing unused setup folder

adding more verbose logging for azure devops failure

fixing pull request branch name resolution bug

fixing pull request branch name resolution bug

addressing nick's pr comments

documenting script and docker images

cleaning up required env var check

fixing base branch bug

Added service plan terraform templates to Azure

Adding tags for resources

Integrate review comments to add random id to name

Add tags, capacity and reserved for service plan

Minor Fixes for documentation

Integrate review comments related to resource naming

Remove Optional and Required in variables.tf

Update variables.tf

Update Service Plan Tier to Isolated

squaching commits

applied base image suggestions from nick

* squashing commits and slimming down the build image

* removing go* path from azure devops pipeline as we removed go mods

* refactoring our azure devops pipeline so it's aligned with the local test runner

* fixing azure devops pipeline bug

* fixing base image build variable reference bug

* Addressing nick's PR comments
manojvazirani pushed a commit to manojvazirani/entref-appservice-containers that referenced this pull request Jul 16, 2020
* # This is a combination of 99 commits.
# This is the 1st commit message:

Adding docker test base image

# This is the commit message microsoft#2:

Adding test files

# This is the commit message microsoft#3:

testing

# This is the commit message microsoft#4:

Added folder

# This is the commit message microsoft#5:

Added folder

# This is the commit message microsoft#6:

Azure Devops CI Build Pipeline (microsoft#67)

* Adding azure devops build pipeline

* Adding README

* Adding azure build badge

# This is the commit message microsoft#7:

saving latest tests

# This is the commit message microsoft#8:

Adding docker test base image (microsoft#68)


# This is the commit message microsoft#9:

EOD checkin

# This is the commit message microsoft#10:

posting latest

# This is the commit message microsoft#11:

eod commits

# This is the commit message microsoft#12:

eod commit

# This is the commit message microsoft#13:

refactored test directory structure

# This is the commit message microsoft#14:

Refactored build

# This is the commit message microsoft#15:

Adding hello world azure simple app

# This is the commit message microsoft#16:

Adding hello world azure simple app

# This is the commit message microsoft#17:

refactoring test harness

# This is the commit message microsoft#18:

refactoring test harness

# This is the commit message microsoft#19:

checking latest

# This is the commit message microsoft#20:

committing latest

# This is the commit message microsoft#21:

checking in latest changes

# This is the commit message microsoft#22:

Checking in latest progress

# This is the commit message microsoft#23:

applying final touches before PR submission

# This is the commit message microsoft#24:

updating azure keyvault secret names

# This is the commit message microsoft#25:

Checking in latest progress

# This is the commit message microsoft#26:

pushing latest pipeline definition

# This is the commit message microsoft#27:

updating build pipeline variable format

# This is the commit message microsoft#28:

updating build pipeline variable format

# This is the commit message microsoft#29:

cleaning up build variables

# This is the commit message microsoft#30:

adding minor changes to azure build pipeline

# This is the commit message microsoft#31:

updating azure keyvault secret names

# This is the commit message microsoft#32:

updating azure keyvault secret names

# This is the commit message microsoft#33:

fixing docker login azdo step

# This is the commit message microsoft#34:

fixing docker login azdo step

# This is the commit message microsoft#35:

fixing docker login azdo step

# This is the commit message microsoft#36:

fixing docker login azdo step

# This is the commit message microsoft#37:

updating build pipeline variables

# This is the commit message microsoft#38:

updating build pipeline variables

# This is the commit message microsoft#39:

updating build pipeline variables

# This is the commit message microsoft#40:

updating build pipeline variables

# This is the commit message microsoft#41:

updating build pipeline variables

# This is the commit message microsoft#42:

updating build pipeline variables

# This is the commit message microsoft#43:

applying fix to git diff script

# This is the commit message microsoft#44:

applying fix to git diff script

# This is the commit message microsoft#45:

applying fix to git diff script

# This is the commit message microsoft#46:

applying fix to git diff script

# This is the commit message microsoft#47:

applying fix to git diff script

# This is the commit message microsoft#48:

resolving pipeline bug

# This is the commit message microsoft#49:

fixing build error

# This is the commit message microsoft#50:

fixing build error

# This is the commit message microsoft#51:

fixing build error

# This is the commit message microsoft#52:

fixing build error

# This is the commit message microsoft#53:

fixing build error

# This is the commit message microsoft#54:

fixing build error

# This is the commit message microsoft#55:

fixing build error

# This is the commit message microsoft#56:

fixing build error

# This is the commit message microsoft#57:

fixing build error

# This is the commit message microsoft#58:

fixing build error

# This is the commit message microsoft#59:

fixing build error

# This is the commit message microsoft#60:

fixing build error

# This is the commit message microsoft#61:

fixing build error

# This is the commit message microsoft#62:

fixing build error

# This is the commit message microsoft#63:

fixing build error

# This is the commit message microsoft#64:

fixing build error

# This is the commit message microsoft#65:

fixing build error

# This is the commit message microsoft#66:

fixing build error

# This is the commit message microsoft#67:

fixing build error

# This is the commit message microsoft#68:

fixing build error

# This is the commit message microsoft#69:

fixing build error

# This is the commit message microsoft#70:

fixing build error

# This is the commit message microsoft#71:

fixing build error

# This is the commit message microsoft#72:

fixing build error

# This is the commit message microsoft#73:

trying acr fix

# This is the commit message microsoft#74:

latest changes

# This is the commit message microsoft#75:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#76:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#77:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#78:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#79:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#80:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#81:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#82:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#83:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#84:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#85:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#86:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#87:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#88:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#89:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#90:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#91:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#92:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#93:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#94:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#95:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#96:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#97:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#98:

final commit including resource name randomization

# This is the commit message microsoft#99:

Add provider to configure az infra for Terraform

* resolving merge conflicts for squash

Updated documentation based on review comments

Integrate review comments for documentation.

Add usage example for each of the providers

Adding environment template descriptions

removing go version var from azdo pipeline as it's unused

removing unused setup folder

adding more verbose logging for azure devops failure

fixing pull request branch name resolution bug

fixing pull request branch name resolution bug

addressing nick's pr comments

documenting script and docker images

cleaning up required env var check

fixing base branch bug

Added service plan terraform templates to Azure

Adding tags for resources

Integrate review comments to add random id to name

Add tags, capacity and reserved for service plan

Minor Fixes for documentation

Integrate review comments related to resource naming

Remove Optional and Required in variables.tf

Update variables.tf

Update Service Plan Tier to Isolated

squaching commits

applied base image suggestions from nick

* squashing commits and slimming down the build image

* removing go* path from azure devops pipeline as we removed go mods

* refactoring our azure devops pipeline so it's aligned with the local test runner

* fixing azure devops pipeline bug

* fixing base image build variable reference bug

* Addressing nick's PR comments

* resolving issue with failed builds after completing branches merges

* addressing a bug where test harness directory changes were not getting picked up by the harness

* removing local echo statement

* Adding directory exists check and app service container command variable

* addressing nick's PR comments

* adding git diff extension whitelist filter
manojvazirani pushed a commit to manojvazirani/entref-appservice-containers that referenced this pull request Jul 16, 2020
* # This is a combination of 99 commits.
# This is the 1st commit message:

Adding docker test base image

# This is the commit message microsoft#2:

Adding test files

# This is the commit message microsoft#3:

testing

# This is the commit message microsoft#4:

Added folder

# This is the commit message microsoft#5:

Added folder

# This is the commit message microsoft#6:

Azure Devops CI Build Pipeline (microsoft#67)

* Adding azure devops build pipeline

* Adding README

* Adding azure build badge

# This is the commit message microsoft#7:

saving latest tests

# This is the commit message microsoft#8:

Adding docker test base image (microsoft#68)


# This is the commit message microsoft#9:

EOD checkin

# This is the commit message microsoft#10:

posting latest

# This is the commit message microsoft#11:

eod commits

# This is the commit message microsoft#12:

eod commit

# This is the commit message microsoft#13:

refactored test directory structure

# This is the commit message microsoft#14:

Refactored build

# This is the commit message microsoft#15:

Adding hello world azure simple app

# This is the commit message microsoft#16:

Adding hello world azure simple app

# This is the commit message microsoft#17:

refactoring test harness

# This is the commit message microsoft#18:

refactoring test harness

# This is the commit message microsoft#19:

checking latest

# This is the commit message microsoft#20:

committing latest

# This is the commit message microsoft#21:

checking in latest changes

# This is the commit message microsoft#22:

Checking in latest progress

# This is the commit message microsoft#23:

applying final touches before PR submission

# This is the commit message microsoft#24:

updating azure keyvault secret names

# This is the commit message microsoft#25:

Checking in latest progress

# This is the commit message microsoft#26:

pushing latest pipeline definition

# This is the commit message microsoft#27:

updating build pipeline variable format

# This is the commit message microsoft#28:

updating build pipeline variable format

# This is the commit message microsoft#29:

cleaning up build variables

# This is the commit message microsoft#30:

adding minor changes to azure build pipeline

# This is the commit message microsoft#31:

updating azure keyvault secret names

# This is the commit message microsoft#32:

updating azure keyvault secret names

# This is the commit message microsoft#33:

fixing docker login azdo step

# This is the commit message microsoft#34:

fixing docker login azdo step

# This is the commit message microsoft#35:

fixing docker login azdo step

# This is the commit message microsoft#36:

fixing docker login azdo step

# This is the commit message microsoft#37:

updating build pipeline variables

# This is the commit message microsoft#38:

updating build pipeline variables

# This is the commit message microsoft#39:

updating build pipeline variables

# This is the commit message microsoft#40:

updating build pipeline variables

# This is the commit message microsoft#41:

updating build pipeline variables

# This is the commit message microsoft#42:

updating build pipeline variables

# This is the commit message microsoft#43:

applying fix to git diff script

# This is the commit message microsoft#44:

applying fix to git diff script

# This is the commit message microsoft#45:

applying fix to git diff script

# This is the commit message microsoft#46:

applying fix to git diff script

# This is the commit message microsoft#47:

applying fix to git diff script

# This is the commit message microsoft#48:

resolving pipeline bug

# This is the commit message microsoft#49:

fixing build error

# This is the commit message microsoft#50:

fixing build error

# This is the commit message microsoft#51:

fixing build error

# This is the commit message microsoft#52:

fixing build error

# This is the commit message microsoft#53:

fixing build error

# This is the commit message microsoft#54:

fixing build error

# This is the commit message microsoft#55:

fixing build error

# This is the commit message microsoft#56:

fixing build error

# This is the commit message microsoft#57:

fixing build error

# This is the commit message microsoft#58:

fixing build error

# This is the commit message microsoft#59:

fixing build error

# This is the commit message microsoft#60:

fixing build error

# This is the commit message microsoft#61:

fixing build error

# This is the commit message microsoft#62:

fixing build error

# This is the commit message microsoft#63:

fixing build error

# This is the commit message microsoft#64:

fixing build error

# This is the commit message microsoft#65:

fixing build error

# This is the commit message microsoft#66:

fixing build error

# This is the commit message microsoft#67:

fixing build error

# This is the commit message microsoft#68:

fixing build error

# This is the commit message microsoft#69:

fixing build error

# This is the commit message microsoft#70:

fixing build error

# This is the commit message microsoft#71:

fixing build error

# This is the commit message microsoft#72:

fixing build error

# This is the commit message microsoft#73:

trying acr fix

# This is the commit message microsoft#74:

latest changes

# This is the commit message microsoft#75:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#76:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#77:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#78:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#79:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#80:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#81:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#82:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#83:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#84:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#85:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#86:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#87:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#88:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#89:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#90:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#91:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#92:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#93:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#94:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#95:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#96:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#97:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#98:

final commit including resource name randomization

# This is the commit message microsoft#99:

Add provider to configure az infra for Terraform

* resolving merge conflicts for squash

Updated documentation based on review comments

Integrate review comments for documentation.

Add usage example for each of the providers

Adding environment template descriptions

removing go version var from azdo pipeline as it's unused

removing unused setup folder

adding more verbose logging for azure devops failure

fixing pull request branch name resolution bug

fixing pull request branch name resolution bug

addressing nick's pr comments

documenting script and docker images

cleaning up required env var check

fixing base branch bug

Added service plan terraform templates to Azure

Adding tags for resources

Integrate review comments to add random id to name

Add tags, capacity and reserved for service plan

Minor Fixes for documentation

Integrate review comments related to resource naming

Remove Optional and Required in variables.tf

Update variables.tf

Update Service Plan Tier to Isolated

squaching commits

applied base image suggestions from nick

* squashing commits and slimming down the build image

* removing go* path from azure devops pipeline as we removed go mods

* refactoring our azure devops pipeline so it's aligned with the local test runner

* fixing azure devops pipeline bug

* fixing base image build variable reference bug

* Addressing nick's PR comments

* resolving issue with failed builds after completing branches merges

* addressing a bug where test harness directory changes were not getting picked up by the harness

* removing local echo statement

* Adding directory exists check and app service container command variable

* addressing nick's PR comments

* adding git diff extension whitelist filter

* Overhauling main project readme

* Adding james to the readme

* Update README.md

* Updating readme from the test-harness directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort - small 1 day effort enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants