Skip to content

Bashwizard integration + docker-free test runner #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 14, 2019
Merged

Bashwizard integration + docker-free test runner #81

merged 20 commits into from
May 14, 2019

Conversation

erikschlegel
Copy link
Contributor

All Submissions:

  • [YES] Have you followed the guidelines in our Contributing document?
  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.
  • [YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Issue Number: closes #56

What is the new behavior?

This pull request covers the following feature additions.

  • Updated test harness getting started and shell script argument options documentation.
  • Refactored all our shell scripts to adhere to the scaffolding format from @joelong01 BashWizard project.
  • Added support for a docker free version of the test harness to minimize local build time for active development scenarios.
  • Added support for template_name_override option for both test harness runners. This allows developers to override the target template folder for automated test runs.
  • Added manifest files to .gitignore
  • Removed overlapping / unused module folders as we're referencing vnet, trafficmanager from bedrock going forward.

Does this introduce a breaking change?

  • [YES]

Any relevant logs, error output, etc?

Local build log for passed test run following change

TestITAzureSimple 2019-05-06T17:01:01-05:00 command.go:121: ?[0m?[1mazurerm_resource_group.main: Still destroying... (ID: /subscriptions/49e3a7a8-c63e-4124-948c-ee51b74d5801/resourceGroups/cobalt-MM8WtJ, 20s elapsed)?[0m?[0m
TestITAzureSimple 2019-05-06T17:01:11-05:00 command.go:121: ?[0m?[1mazurerm_resource_group.main: Still destroying... (ID: /subscriptions/49e3a7a8-c63e-4124-948c-ee51b74d5801/resourceGroups/cobalt-MM8WtJ, 30s elapsed)?[0m?[0m
TestITAzureSimple 2019-05-06T17:01:21-05:00 command.go:121: ?[0m?[1mazurerm_resource_group.main: Still destroying... (ID: /subscriptions/49e3a7a8-c63e-4124-948c-ee51b74d5801/resourceGroups/cobalt-MM8WtJ, 40s elapsed)?[0m?[0m
TestITAzureSimple 2019-05-06T17:01:27-05:00 command.go:121: ?[0m?[1mazurerm_resource_group.main: Destruction complete after 46s?[0m?[0m
TestITAzureSimple 2019-05-06T17:01:28-05:00 command.go:121: ?[0m?[1m?[32m
TestITAzureSimple 2019-05-06T17:01:28-05:00 command.go:121: Destroy complete! Resources: 3 destroyed.?[0m
--- PASS: TestITAzureSimple (209.33s)
PASS
ok      cobalt/build/azure-simple-hw/test/integration   209.467s
/c/Users/erisch/go/src/cobalt

@erikschlegel erikschlegel requested a review from James-Nance May 6, 2019 22:28
@erikschlegel erikschlegel added this to the Sprint 2 milestone May 6, 2019
@erikschlegel erikschlegel added the enhancement New feature or request label May 6, 2019
@joelong01
Copy link

joelong01 commented May 6, 2019 via email

@NathanielRose
Copy link

Looks like the msftcse image is private on docker hub.

@NathanielRose
Copy link

Running the docker image out of box and receiving an error:

Successfully tagged msftcse/cobalt-test-base:g1.11.5t0.11.13
nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$
nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$ ./test-harness/local-run.sh
INFO: loading environment
INFO: Checking required environment variables
INFO: passed environment variable check
local-run.sh:
t0.11.13er_base_image_name...................... msftcse/cobalt-test-base:g1.11.5
    tf_state_storage_acct...... cobaltfstate
    tf_state_container.... cobaltfstate-remote-state-container
    template_name_override....
INFO: verified that environment is fully defined
INFO: verified that environment is fully defined
INFO: Running git diff from branch (HEAD
fatal: ambiguous argument '(HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
INFO: No templates to process. Exiting build step

@NathanielRose
Copy link

Local running of the script gives the following output:

nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$ ./test-harness/local-run-wo-docker.sh
INFO: loading environment
INFO: Checking required environment variables
INFO: passed environment variable check
local-run-wo-docker.sh:
    tf_state_storage_acct...... cobaltfstate
    tf_state_container.... cobaltfstate-remote-state-container
    template_name_override....
INFO: verified that environment is fully defined
INFO: Setting up golang manifest and vendor packages
init failed: unable to detect the containing GOPATH: /mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt is not within a known GOPATH/src

@NathanielRose NathanielRose mentioned this pull request May 7, 2019
Closed
7 tasks
@erikschlegel
Copy link
Contributor Author

Looks like the msftcse image is private on docker hub.

The public image can be found in the msftcse/cobalt-test-base repo here. Updated the documentation to be more clear.

@erikschlegel
Copy link
Contributor Author

Running the docker image out of box and receiving an error:

Successfully tagged msftcse/cobalt-test-base:g1.11.5t0.11.13
nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$
nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$ ./test-harness/local-run.sh
INFO: loading environment
INFO: Checking required environment variables
INFO: passed environment variable check
local-run.sh:
t0.11.13er_base_image_name...................... msftcse/cobalt-test-base:g1.11.5
    tf_state_storage_acct...... cobaltfstate
    tf_state_container.... cobaltfstate-remote-state-container
    template_name_override....
INFO: verified that environment is fully defined
INFO: verified that environment is fully defined
INFO: Running git diff from branch (HEAD
fatal: ambiguous argument '(HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
INFO: No templates to process. Exiting build step

can you provide the output of git branch?

@erikschlegel
Copy link
Contributor Author

erikschlegel commented May 7, 2019 •
edited
Loading

Local running of the script gives the following output:

nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$ ./test-harness/local-run-wo-docker.sh
INFO: loading environment
INFO: Checking required environment variables
INFO: passed environment variable check
local-run-wo-docker.sh:
    tf_state_storage_acct...... cobaltfstate
    tf_state_container.... cobaltfstate-remote-state-container
    template_name_override....
INFO: verified that environment is fully defined
INFO: Setting up golang manifest and vendor packages
init failed: unable to detect the containing GOPATH: /mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt is not within a known GOPATH/src

Please confirm that all prereq conditions are accounted for? Especially "Create your working directory within your GOPATH." Golang requires your project to be a subdirectory within $GOPATH/src. Here's some more context. 😃

@NathanielRose
Copy link

Running the docker image out of box and receiving an error:

Successfully tagged msftcse/cobalt-test-base:g1.11.5t0.11.13
nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$
nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$ ./test-harness/local-run.sh
INFO: loading environment
INFO: Checking required environment variables
INFO: passed environment variable check
local-run.sh:
t0.11.13er_base_image_name...................... msftcse/cobalt-test-base:g1.11.5
    tf_state_storage_acct...... cobaltfstate
    tf_state_container.... cobaltfstate-remote-state-container
    template_name_override....
INFO: verified that environment is fully defined
INFO: verified that environment is fully defined
INFO: Running git diff from branch (HEAD
fatal: ambiguous argument '(HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
INFO: No templates to process. Exiting build step

can you provide the output of git branch?

nmrose@MININT-IQPVRH0:/mnt/c/Users/naros/Desktop/FY19/cobalt/cobalt$ git branch
(HEAD detached at origin/erisch/features/bashwizard) 🙂

@erikschlegel erikschlegel requested a review from NathanielRose May 8, 2019 00:49
nmiodice
nmiodice reviewed May 13, 2019
View reviewed changes
NathanielRose
NathanielRose previously approved these changes May 14, 2019
View reviewed changes
Copy link

@NathanielRose NathanielRose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running on WSL 👍

NathanielRose
NathanielRose approved these changes May 14, 2019
View reviewed changes
Copy link

@NathanielRose NathanielRose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - Will eventually want to further investigate go.mod to move outside go/src.

@erikschlegel erikschlegel merged commit d72b1fb into master May 14, 2019
@erikschlegel
Copy link
Contributor Author

LGTM! - Will eventually want to further investigate go.mod to move outside go/src.

Thanks for the review @NathanielRose . Let us know how we can help with migrating from dep -> go.mod 🚀

@erikschlegel erikschlegel deleted the erisch/features/bashwizard branch May 15, 2019 18:09
manojvazirani pushed a commit to manojvazirani/entref-appservice-containers that referenced this pull request Jul 16, 2020
@erikschlegel
Erisch/features/devops/integration tests (microsoft#75)
5070b66 
* # This is a combination of 99 commits.
# This is the 1st commit message:

Adding docker test base image

# This is the commit message microsoft#2:

Adding test files

# This is the commit message microsoft#3:

testing

# This is the commit message microsoft#4:

Added folder

# This is the commit message microsoft#5:

Added folder

# This is the commit message microsoft#6:

Azure Devops CI Build Pipeline (microsoft#67)

* Adding azure devops build pipeline

* Adding README

* Adding azure build badge

# This is the commit message microsoft#7:

saving latest tests

# This is the commit message microsoft#8:

Adding docker test base image (microsoft#68)


# This is the commit message microsoft#9:

EOD checkin

# This is the commit message microsoft#10:

posting latest

# This is the commit message microsoft#11:

eod commits

# This is the commit message microsoft#12:

eod commit

# This is the commit message microsoft#13:

refactored test directory structure

# This is the commit message microsoft#14:

Refactored build

# This is the commit message microsoft#15:

Adding hello world azure simple app

# This is the commit message microsoft#16:

Adding hello world azure simple app

# This is the commit message microsoft#17:

refactoring test harness

# This is the commit message microsoft#18:

refactoring test harness

# This is the commit message microsoft#19:

checking latest

# This is the commit message microsoft#20:

committing latest

# This is the commit message microsoft#21:

checking in latest changes

# This is the commit message microsoft#22:

Checking in latest progress

# This is the commit message microsoft#23:

applying final touches before PR submission

# This is the commit message microsoft#24:

updating azure keyvault secret names

# This is the commit message microsoft#25:

Checking in latest progress

# This is the commit message microsoft#26:

pushing latest pipeline definition

# This is the commit message microsoft#27:

updating build pipeline variable format

# This is the commit message microsoft#28:

updating build pipeline variable format

# This is the commit message microsoft#29:

cleaning up build variables

# This is the commit message microsoft#30:

adding minor changes to azure build pipeline

# This is the commit message microsoft#31:

updating azure keyvault secret names

# This is the commit message microsoft#32:

updating azure keyvault secret names

# This is the commit message microsoft#33:

fixing docker login azdo step

# This is the commit message microsoft#34:

fixing docker login azdo step

# This is the commit message microsoft#35:

fixing docker login azdo step

# This is the commit message microsoft#36:

fixing docker login azdo step

# This is the commit message microsoft#37:

updating build pipeline variables

# This is the commit message microsoft#38:

updating build pipeline variables

# This is the commit message microsoft#39:

updating build pipeline variables

# This is the commit message microsoft#40:

updating build pipeline variables

# This is the commit message microsoft#41:

updating build pipeline variables

# This is the commit message microsoft#42:

updating build pipeline variables

# This is the commit message microsoft#43:

applying fix to git diff script

# This is the commit message microsoft#44:

applying fix to git diff script

# This is the commit message microsoft#45:

applying fix to git diff script

# This is the commit message microsoft#46:

applying fix to git diff script

# This is the commit message microsoft#47:

applying fix to git diff script

# This is the commit message microsoft#48:

resolving pipeline bug

# This is the commit message microsoft#49:

fixing build error

# This is the commit message microsoft#50:

fixing build error

# This is the commit message microsoft#51:

fixing build error

# This is the commit message microsoft#52:

fixing build error

# This is the commit message microsoft#53:

fixing build error

# This is the commit message microsoft#54:

fixing build error

# This is the commit message microsoft#55:

fixing build error

# This is the commit message microsoft#56:

fixing build error

# This is the commit message microsoft#57:

fixing build error

# This is the commit message microsoft#58:

fixing build error

# This is the commit message microsoft#59:

fixing build error

# This is the commit message microsoft#60:

fixing build error

# This is the commit message microsoft#61:

fixing build error

# This is the commit message microsoft#62:

fixing build error

# This is the commit message microsoft#63:

fixing build error

# This is the commit message microsoft#64:

fixing build error

# This is the commit message microsoft#65:

fixing build error

# This is the commit message microsoft#66:

fixing build error

# This is the commit message microsoft#67:

fixing build error

# This is the commit message microsoft#68:

fixing build error

# This is the commit message microsoft#69:

fixing build error

# This is the commit message microsoft#70:

fixing build error

# This is the commit message microsoft#71:

fixing build error

# This is the commit message microsoft#72:

fixing build error

# This is the commit message microsoft#73:

trying acr fix

# This is the commit message microsoft#74:

latest changes

# This is the commit message microsoft#75:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#76:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#77:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#78:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#79:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#80:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#81:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#82:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#83:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#84:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#85:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#86:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#87:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#88:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#89:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#90:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#91:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#92:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#93:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#94:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#95:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#96:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#97:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#98:

final commit including resource name randomization

# This is the commit message microsoft#99:

Add provider to configure az infra for Terraform

* resolving merge conflicts for squash

Updated documentation based on review comments

Integrate review comments for documentation.

Add usage example for each of the providers

Adding environment template descriptions

removing go version var from azdo pipeline as it's unused

removing unused setup folder

adding more verbose logging for azure devops failure

fixing pull request branch name resolution bug

fixing pull request branch name resolution bug

addressing nick's pr comments

documenting script and docker images

cleaning up required env var check

fixing base branch bug

Added service plan terraform templates to Azure

Adding tags for resources

Integrate review comments to add random id to name

Add tags, capacity and reserved for service plan

Minor Fixes for documentation

Integrate review comments related to resource naming

Remove Optional and Required in variables.tf

Update variables.tf

Update Service Plan Tier to Isolated

squaching commits

applied base image suggestions from nick

* squashing commits and slimming down the build image

* removing go* path from azure devops pipeline as we removed go mods

* refactoring our azure devops pipeline so it's aligned with the local test runner

* fixing azure devops pipeline bug

* fixing base image build variable reference bug

* Addressing nick's PR comments
manojvazirani pushed a commit to manojvazirani/entref-appservice-containers that referenced this pull request Jul 16, 2020
@erikschlegel
Integration test fix for branch merges (microsoft#78)
e6cdf65 
* # This is a combination of 99 commits.
# This is the 1st commit message:

Adding docker test base image

# This is the commit message microsoft#2:

Adding test files

# This is the commit message microsoft#3:

testing

# This is the commit message microsoft#4:

Added folder

# This is the commit message microsoft#5:

Added folder

# This is the commit message microsoft#6:

Azure Devops CI Build Pipeline (microsoft#67)

* Adding azure devops build pipeline

* Adding README

* Adding azure build badge

# This is the commit message microsoft#7:

saving latest tests

# This is the commit message microsoft#8:

Adding docker test base image (microsoft#68)


# This is the commit message microsoft#9:

EOD checkin

# This is the commit message microsoft#10:

posting latest

# This is the commit message microsoft#11:

eod commits

# This is the commit message microsoft#12:

eod commit

# This is the commit message microsoft#13:

refactored test directory structure

# This is the commit message microsoft#14:

Refactored build

# This is the commit message microsoft#15:

Adding hello world azure simple app

# This is the commit message microsoft#16:

Adding hello world azure simple app

# This is the commit message microsoft#17:

refactoring test harness

# This is the commit message microsoft#18:

refactoring test harness

# This is the commit message microsoft#19:

checking latest

# This is the commit message microsoft#20:

committing latest

# This is the commit message microsoft#21:

checking in latest changes

# This is the commit message microsoft#22:

Checking in latest progress

# This is the commit message microsoft#23:

applying final touches before PR submission

# This is the commit message microsoft#24:

updating azure keyvault secret names

# This is the commit message microsoft#25:

Checking in latest progress

# This is the commit message microsoft#26:

pushing latest pipeline definition

# This is the commit message microsoft#27:

updating build pipeline variable format

# This is the commit message microsoft#28:

updating build pipeline variable format

# This is the commit message microsoft#29:

cleaning up build variables

# This is the commit message microsoft#30:

adding minor changes to azure build pipeline

# This is the commit message microsoft#31:

updating azure keyvault secret names

# This is the commit message microsoft#32:

updating azure keyvault secret names

# This is the commit message microsoft#33:

fixing docker login azdo step

# This is the commit message microsoft#34:

fixing docker login azdo step

# This is the commit message microsoft#35:

fixing docker login azdo step

# This is the commit message microsoft#36:

fixing docker login azdo step

# This is the commit message microsoft#37:

updating build pipeline variables

# This is the commit message microsoft#38:

updating build pipeline variables

# This is the commit message microsoft#39:

updating build pipeline variables

# This is the commit message microsoft#40:

updating build pipeline variables

# This is the commit message microsoft#41:

updating build pipeline variables

# This is the commit message microsoft#42:

updating build pipeline variables

# This is the commit message microsoft#43:

applying fix to git diff script

# This is the commit message microsoft#44:

applying fix to git diff script

# This is the commit message microsoft#45:

applying fix to git diff script

# This is the commit message microsoft#46:

applying fix to git diff script

# This is the commit message microsoft#47:

applying fix to git diff script

# This is the commit message microsoft#48:

resolving pipeline bug

# This is the commit message microsoft#49:

fixing build error

# This is the commit message microsoft#50:

fixing build error

# This is the commit message microsoft#51:

fixing build error

# This is the commit message microsoft#52:

fixing build error

# This is the commit message microsoft#53:

fixing build error

# This is the commit message microsoft#54:

fixing build error

# This is the commit message microsoft#55:

fixing build error

# This is the commit message microsoft#56:

fixing build error

# This is the commit message microsoft#57:

fixing build error

# This is the commit message microsoft#58:

fixing build error

# This is the commit message microsoft#59:

fixing build error

# This is the commit message microsoft#60:

fixing build error

# This is the commit message microsoft#61:

fixing build error

# This is the commit message microsoft#62:

fixing build error

# This is the commit message microsoft#63:

fixing build error

# This is the commit message microsoft#64:

fixing build error

# This is the commit message microsoft#65:

fixing build error

# This is the commit message microsoft#66:

fixing build error

# This is the commit message microsoft#67:

fixing build error

# This is the commit message microsoft#68:

fixing build error

# This is the commit message microsoft#69:

fixing build error

# This is the commit message microsoft#70:

fixing build error

# This is the commit message microsoft#71:

fixing build error

# This is the commit message microsoft#72:

fixing build error

# This is the commit message microsoft#73:

trying acr fix

# This is the commit message microsoft#74:

latest changes

# This is the commit message microsoft#75:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#76:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#77:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#78:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#79:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#80:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#81:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#82:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#83:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#84:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#85:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#86:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#87:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#88:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#89:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#90:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#91:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#92:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#93:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#94:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#95:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#96:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#97:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#98:

final commit including resource name randomization

# This is the commit message microsoft#99:

Add provider to configure az infra for Terraform

* resolving merge conflicts for squash

Updated documentation based on review comments

Integrate review comments for documentation.

Add usage example for each of the providers

Adding environment template descriptions

removing go version var from azdo pipeline as it's unused

removing unused setup folder

adding more verbose logging for azure devops failure

fixing pull request branch name resolution bug

fixing pull request branch name resolution bug

addressing nick's pr comments

documenting script and docker images

cleaning up required env var check

fixing base branch bug

Added service plan terraform templates to Azure

Adding tags for resources

Integrate review comments to add random id to name

Add tags, capacity and reserved for service plan

Minor Fixes for documentation

Integrate review comments related to resource naming

Remove Optional and Required in variables.tf

Update variables.tf

Update Service Plan Tier to Isolated

squaching commits

applied base image suggestions from nick

* squashing commits and slimming down the build image

* removing go* path from azure devops pipeline as we removed go mods

* refactoring our azure devops pipeline so it's aligned with the local test runner

* fixing azure devops pipeline bug

* fixing base image build variable reference bug

* Addressing nick's PR comments

* resolving issue with failed builds after completing branches merges

* addressing a bug where test harness directory changes were not getting picked up by the harness

* removing local echo statement

* Adding directory exists check and app service container command variable

* addressing nick's PR comments

* adding git diff extension whitelist filter
manojvazirani pushed a commit to manojvazirani/entref-appservice-containers that referenced this pull request Jul 16, 2020
@erikschlegel
Update main project readme (microsoft#79)
0de406e 
* # This is a combination of 99 commits.
# This is the 1st commit message:

Adding docker test base image

# This is the commit message microsoft#2:

Adding test files

# This is the commit message microsoft#3:

testing

# This is the commit message microsoft#4:

Added folder

# This is the commit message microsoft#5:

Added folder

# This is the commit message microsoft#6:

Azure Devops CI Build Pipeline (microsoft#67)

* Adding azure devops build pipeline

* Adding README

* Adding azure build badge

# This is the commit message microsoft#7:

saving latest tests

# This is the commit message microsoft#8:

Adding docker test base image (microsoft#68)


# This is the commit message microsoft#9:

EOD checkin

# This is the commit message microsoft#10:

posting latest

# This is the commit message microsoft#11:

eod commits

# This is the commit message microsoft#12:

eod commit

# This is the commit message microsoft#13:

refactored test directory structure

# This is the commit message microsoft#14:

Refactored build

# This is the commit message microsoft#15:

Adding hello world azure simple app

# This is the commit message microsoft#16:

Adding hello world azure simple app

# This is the commit message microsoft#17:

refactoring test harness

# This is the commit message microsoft#18:

refactoring test harness

# This is the commit message microsoft#19:

checking latest

# This is the commit message microsoft#20:

committing latest

# This is the commit message microsoft#21:

checking in latest changes

# This is the commit message microsoft#22:

Checking in latest progress

# This is the commit message microsoft#23:

applying final touches before PR submission

# This is the commit message microsoft#24:

updating azure keyvault secret names

# This is the commit message microsoft#25:

Checking in latest progress

# This is the commit message microsoft#26:

pushing latest pipeline definition

# This is the commit message microsoft#27:

updating build pipeline variable format

# This is the commit message microsoft#28:

updating build pipeline variable format

# This is the commit message microsoft#29:

cleaning up build variables

# This is the commit message microsoft#30:

adding minor changes to azure build pipeline

# This is the commit message microsoft#31:

updating azure keyvault secret names

# This is the commit message microsoft#32:

updating azure keyvault secret names

# This is the commit message microsoft#33:

fixing docker login azdo step

# This is the commit message microsoft#34:

fixing docker login azdo step

# This is the commit message microsoft#35:

fixing docker login azdo step

# This is the commit message microsoft#36:

fixing docker login azdo step

# This is the commit message microsoft#37:

updating build pipeline variables

# This is the commit message microsoft#38:

updating build pipeline variables

# This is the commit message microsoft#39:

updating build pipeline variables

# This is the commit message microsoft#40:

updating build pipeline variables

# This is the commit message microsoft#41:

updating build pipeline variables

# This is the commit message microsoft#42:

updating build pipeline variables

# This is the commit message microsoft#43:

applying fix to git diff script

# This is the commit message microsoft#44:

applying fix to git diff script

# This is the commit message microsoft#45:

applying fix to git diff script

# This is the commit message microsoft#46:

applying fix to git diff script

# This is the commit message microsoft#47:

applying fix to git diff script

# This is the commit message microsoft#48:

resolving pipeline bug

# This is the commit message microsoft#49:

fixing build error

# This is the commit message microsoft#50:

fixing build error

# This is the commit message microsoft#51:

fixing build error

# This is the commit message microsoft#52:

fixing build error

# This is the commit message microsoft#53:

fixing build error

# This is the commit message microsoft#54:

fixing build error

# This is the commit message microsoft#55:

fixing build error

# This is the commit message microsoft#56:

fixing build error

# This is the commit message microsoft#57:

fixing build error

# This is the commit message microsoft#58:

fixing build error

# This is the commit message microsoft#59:

fixing build error

# This is the commit message microsoft#60:

fixing build error

# This is the commit message microsoft#61:

fixing build error

# This is the commit message microsoft#62:

fixing build error

# This is the commit message microsoft#63:

fixing build error

# This is the commit message microsoft#64:

fixing build error

# This is the commit message microsoft#65:

fixing build error

# This is the commit message microsoft#66:

fixing build error

# This is the commit message microsoft#67:

fixing build error

# This is the commit message microsoft#68:

fixing build error

# This is the commit message microsoft#69:

fixing build error

# This is the commit message microsoft#70:

fixing build error

# This is the commit message microsoft#71:

fixing build error

# This is the commit message microsoft#72:

fixing build error

# This is the commit message microsoft#73:

trying acr fix

# This is the commit message microsoft#74:

latest changes

# This is the commit message microsoft#75:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#76:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#77:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#78:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#79:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#80:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#81:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#82:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#83:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#84:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#85:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#86:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#87:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#88:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#89:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#90:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#91:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#92:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#93:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#94:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#95:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#96:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#97:

removing docker dependency on azure devops pipeline

# This is the commit message microsoft#98:

final commit including resource name randomization

# This is the commit message microsoft#99:

Add provider to configure az infra for Terraform

* resolving merge conflicts for squash

Updated documentation based on review comments

Integrate review comments for documentation.

Add usage example for each of the providers

Adding environment template descriptions

removing go version var from azdo pipeline as it's unused

removing unused setup folder

adding more verbose logging for azure devops failure

fixing pull request branch name resolution bug

fixing pull request branch name resolution bug

addressing nick's pr comments

documenting script and docker images

cleaning up required env var check

fixing base branch bug

Added service plan terraform templates to Azure

Adding tags for resources

Integrate review comments to add random id to name

Add tags, capacity and reserved for service plan

Minor Fixes for documentation

Integrate review comments related to resource naming

Remove Optional and Required in variables.tf

Update variables.tf

Update Service Plan Tier to Isolated

squaching commits

applied base image suggestions from nick

* squashing commits and slimming down the build image

* removing go* path from azure devops pipeline as we removed go mods

* refactoring our azure devops pipeline so it's aligned with the local test runner

* fixing azure devops pipeline bug

* fixing base image build variable reference bug

* Addressing nick's PR comments

* resolving issue with failed builds after completing branches merges

* addressing a bug where test harness directory changes were not getting picked up by the harness

* removing local echo statement

* Adding directory exists check and app service container command variable

* addressing nick's PR comments

* adding git diff extension whitelist filter

* Overhauling main project readme

* Adding james to the readme

* Update README.md

* Updating readme from the test-harness directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmiodice nmiodice nmiodice left review comments

@NathanielRose NathanielRose NathanielRose approved these changes

@James-Nance James-Nance Awaiting requested review from James-Nance

Assignees

@nmiodice nmiodice

@NathanielRose NathanielRose

@code4clouds code4clouds

@manojvazirani manojvazirani

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.

As a developer, I want to run integration tests for each CI build run
6 participants
@erikschlegel @joelong01 @NathanielRose @nmiodice @code4clouds @manojvazirani