As a developer, I can configure and deploy Azure App Service

[James-Nance]

Description

As a developer, I can configure and deploy Azure App Service

For Cobalt, App Service should provide:

• App/container hosting
• Public IP mapped to container port (Dependency on Julio Research)
• Load balancing (Another User story for scale out config)

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

• Service plan is already deployed before starting deployment of app service

• Key value pair for app service name and linux fx version

• open question: service aplan module depends on app service

• [ ]Output in readme with an example output

• VNET is an option for App Service. (No data block needed)

• No hardcoded variables in module config; everything set through Terraform template

• Usage referenced in Azure Simple template

• Screenshot showing resource provisioned in Azure Portal

Also, here are a few points that need to be addressed:

1. No hardcoded variables in module config; everything set through Terraform template

Resources

Tasks

Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic.
Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)

Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)

Assignee should break down work into tasks here

[code4clouds]

App Service requires App Service Environment (ASE) to be in the same vnet as the AppGateway (If we are to follow the Game Plan).

[code4clouds]

From the Game Plan diagram there is no public IP mapped on the App Service as the traffic is routed through the VNET and directed by the App Gateway... As in Traffic Manager-(public)->App Gateway-(vnet)->App Service.

[code4clouds]

Should the key/secrets for ACR be wired to the Azure Key Vault?

[James-Nance]

Should the key/secrets for ACR be wired to the Azure Key Vault?

ACR and Key Vault would normally be managed by the dev / org, so not within scope of this (per the architecture diagram) infrastructure. I'd say do what you need to do for testing purposes, but nothing should be hard-coded in the modules or templates. Sorry if I'm misunderstanding the question.

[code4clouds]

Agree. They are both managed by the org, but they still need to be "wired/configured" to the module or access by the template (#63 ) and sent down to this module.

[erikschlegel]

The deployment is happening as part of the test harness which sets the service principal credentials in the environment automatically. In summary, KV integration is already accounted for as you set this in your .env file. Erik

…

________________________________ From: Julio Colon <notifications@github.com> Sent: Friday, April 26, 2019 12:44 PM To: Microsoft/cobalt Cc: Erik Schlegel; Comment Subject: Re: [Microsoft/cobalt] As a developer, I can configure and deploy Azure App Service (#60) Agree. They are both managed by the org, but they still need to be "wired/configured" to the module or access by the template (#63<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fcobalt%2Fissues%2F63&data=01%7C01%7Cerisch%40microsoft.com%7C7936b4cdc2a7409d8ba208d6ca6ee343%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=uUhpUASzGCKzXJgQPeF6L4YwPzPo3ZRo1QNJZbKNQPA%3D&reserved=0> ) and sent down to this module. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fcobalt%2Fissues%2F60%23issuecomment-487142238&data=01%7C01%7Cerisch%40microsoft.com%7C7936b4cdc2a7409d8ba208d6ca6ee343%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=Jo%2Bv4Ybag6D4EfpLdLjFyvTCocbopLJANcU9ZZ09vcE%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB2IHGP7FIFV5GKTH44BKUDPSM5RJANCNFSM4HFSL6EQ&data=01%7C01%7Cerisch%40microsoft.com%7C7936b4cdc2a7409d8ba208d6ca6ee343%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=JP7%2B6xlXArSMPdL2qzj%2BUHH3JhNgvxUvFbBVkMfa%2BPM%3D&reserved=0>.