-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cascadia Code Upright bugfixes #482
Conversation
…ances For whatever reason glyphslib sets the familyName of the font to include the "Italic" name. I had corrected the variable font instance, but not the static instances.
Double-checked to make sure that the hinting didn't break in fixing these.
I was there. I updated it.
Still need to hint, but moving along?
- resolving more interpolation fun - updating hints
Also, remember friends, there are more fixes to come! So If you don't see yours yet, don't worry. I've got everything on the backlog :) |
😄 and I do very much appreciate the work you do here |
Nope. :) |
lol |
Couple followup questions (sorry: I am out of my depth, and if my questions are annoying please let me know!)
|
UGH, Okay, ignore me. Only the I was looking at the diff the wrong way. 19 years of software engineering and this is what I've done to myself. Only the |
👍 It happens! The background can be deleted. I usually clear them out of the source on my end but must have re-added some by accident. |
In that case, it does look like the .fea and .glif files are growing support for Hebrew and Arabic (there's a lot of them added in this PR) |
Yup! All of that stuff is disabled for now. But once we have the rest of the bits ready I’ll turn it all back on. |
Oh this is great! Will the glyphs not even be included in the final font? This is so cool |
Nope. They’ve been set as non-exporting. |
Summary of the Pull Request
A large set of bug fixes identified while working on the Italic, but solving Github reported issues.
PR Checklist
=>>
<<=
=<<
and>>=
(the infinite arrows still work with addition of more equals)Other Cascadia Code fixes:
rclt
).I do enjoy giving Dustin presents.