Fix ChoicePrompt ListStyle.none when set via PromptOptions #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mdrichardson could you take a look to at step 7 of this guide and check that the PR is compliant with the latest version of the black formatter? Thanks! |
|
@axelsrz Done. Not sure if we want to merge yet as the base PR hasn't been merged/approved. My only concern is using an ugly ternary vs. an easier-to-understand if statement. |
|
Can this be merged or is there still an issue? |
|
@tracyboehrer I wouldn't say there's an issue so much as the JS PR hasn't been approved. I think it's good to go. @cleemullins, good to merge this and the linked JS PR? |
|
I've added some reviewers (Axel / Steven). Once one of them signs off (or any qualified reviewer) then we can merge. |
axelsrz
approved these changes
Nov 5, 2019
Virtual-Josh
pushed a commit
that referenced
this pull request
Nov 20, 2019
* fix ChoicePrompt none style when set via options * black compat
johnataylor
pushed a commit
that referenced
this pull request
Nov 27, 2019
* initial commit for Teams work * initial commit for Teams * adding teams activity handler, team info, and teams channel account classes * adding conversation update scenario * fixing linting issues * updating classes to use standard attrs * cleaning up PR feedback * adding line * adding another blank line * adding mentions bot and fixing bug for resource response IDs * Threading helper workaround * Corrected case of "teams" folder name in core. Corrected __init__.py in schema so TeamsChannelAccount was defined. * adding mention bot updating mention bot cleaning up linter removing readme, removing self from on_error * resolving merge conflict * adding mention bot cleaning up linter * updating linting * adding mention bot updating mention bot cleaning up linter removing readme, removing self from on_error * resolving merge conflict * adding mention bot cleaning up linter * updating linting * Added 43.complex-dialog * Pinned dependencies in all libraries * adding activity update and delete * adding list for activities * cleaning up config * Pinned dependencies in libraries (missed some setup.py) * modify echo to work out of the box w/ ARM template * Added 47.inspection (#381) * Added 47.inspection, corrected README in 45.state-management * Changed the on_error function to be unbound for consistency. * ChoiceFactory.for_channel was erroneously returning a List instead of an Activity (#383) * Refactored to unbound on_error methods when accessing outer app.py va… (#385) * Refactored to unbound on_error methods when accessing outer app.py variables. * Removed unused imports * Added 16.proactive-messages (#413) * Added 19.custom-dialogs (#411) * Fix ChoicePrompt ListStyle.none when set via PromptOptions (#373) * fix ChoicePrompt none style when set via options * black compat * Added 18.bot-authentication (#419) * Added 17.multilingual-bot * Added 23.facebook-events sample * 23.facebook-events: on_error is now an unbound function * Partial 15.handling-attachments * Removing unnecesary encoding * Added 15.handling-attachments * 17.multilingual-bot suggested corrections * 15.handling-attachments suggested corrections * pylint and black, suggested corrections. * pylint and black changes. No logic changes. (#427) * Fixes #425: Using incorrect BotState (#426) * Added send_activities and updated the logic * pylint: Added send_activities and updated the logic * pylint: Added send_activities and updated the logic * black formatter: Added send_activities and updated the logic * Added 11.qnamaker (#429) * Added 40.timex resolution (#430) * Unfinished push until recognizers-text is updated. * Added 40.timex-resolution * Added 42.scaleout (#435) * Pinned pytest version (#438) * updating linting * fixing linting * initial commit for Teams work * initial commit for Teams * adding teams activity handler, team info, and teams channel account classes * adding conversation update scenario * fixing linting issues * updating classes to use standard attrs * cleaning up PR feedback * adding line * adding another blank line * Corrected case of "teams" folder name in core. Corrected __init__.py in schema so TeamsChannelAccount was defined. * removing extension file * resovling conflict * more merge conflict resolution * fixing linting * fixing conflicts * adding updated teams activity handler * updating None check * updating activity handler and fixing spacing issue * updating activity handler and tests * updating teams activity handler * removing constant * adding tests and removing constant * moving scenarios to root * updating attr check, using .seralize(), removing return * rerunnign black * updating names * updating loop to downcast * member not memeber * adding s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity for microsoft/botbuilder-js#1373
There's a couple of tests that weren't passing prior to this change. There's a test already in place that tests for this, as well.