[#1670][Dialogs] Remove hardcoded InputHint for AttachmentPrompt #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
Jun 15, 2021
|
@denscollo or @santgr11 Can you update from main again and I'll get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor -> replace for fixes x when promoted
Fixes #1670
Description
This PR fixes the issue with the attachment prompt forcing the Input Hint on prompt and adds a new unit test to validate the change.
Specific Changes
attachment_prompt.pythat force the input_hint.test_attachment_prompt_with_input_hintthat uses an activity with the input hint set, and validates that when used the properties are not changed.Testing
Below is the added unit test working before and after the change is applied.
And below is the 05.multi-turn botbuilder sample using the library with the changes applied.
