Skip to content

skill dialog delete conversation id #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2020
Merged

skill dialog delete conversation id #1395

merged 2 commits into from
Oct 5, 2020

Conversation

axelsrz
Copy link
Member

@axelsrz axelsrz commented Oct 1, 2020

Fixes #1373

@axelsrz axelsrz requested a review from tracyboehrer October 1, 2020 23:07
@axelsrz axelsrz requested a review from EricDahlvang October 3, 2020 01:23
@tracyboehrer tracyboehrer merged commit 5807899 into main Oct 5, 2020
@tracyboehrer tracyboehrer deleted the axsuarez/skillDialogDeleteConversationId branch October 5, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SkillDialog doesn't call SkillConversationIdFactory.DeleteConversationReference when using ExpectReplies
2 participants
@axelsrz @tracyboehrer