fixing linting

Author: Virtual-Josh

libraries/botbuilder-core/botbuilder/core/teams/teams_info.py

@@ -12,6 +12,7 @@
 from botframework.connector.aio import ConnectorClient
 from botframework.connector.teams.teams_connector_client import TeamsConnectorClient
 
+
 class TeamsInfo:
     @staticmethod
     def get_team_details(turn_context: TurnContext, team_id: str = "") -> TeamDetails:
@@ -23,20 +24,28 @@ def get_team_details(turn_context: TurnContext, team_id: str = "") -> TeamDetail
                 "TeamsInfo.get_team_details: method is only valid within the scope of MS Teams Team."
             )
 
-        return TeamsInfo.get_teams_connector_client(turn_context).teams.get_team_details(team_id)
+        return TeamsInfo.get_teams_connector_client(
+            turn_context
+        ).teams.get_team_details(team_id)
 
     @staticmethod
-    def get_team_channels(turn_context: TurnContext, team_id: str = "") -> List[ChannelInfo]:
+    def get_team_channels(
+        turn_context: TurnContext, team_id: str = ""
+    ) -> List[ChannelInfo]:
         if not team_id:
             team_id = TeamsInfo.get_team_id(turn_context)
 
         if not team_id:
             raise TypeError(
                 "TeamsInfo.get_team_channels: method is only valid within the scope of MS Teams Team."
             )
-        
-        return TeamsInfo.get_teams_connector_client(turn_context).teams.get_teams_channels(team_id).conversations
-        
+
+        return (
+            TeamsInfo.get_teams_connector_client(turn_context)
+            .teams.get_teams_channels(team_id)
+            .conversations
+        )
+
     @staticmethod
     async def get_team_members(turn_context: TurnContext, team_id: str = ""):
         if not team_id:
@@ -47,49 +56,60 @@ async def get_team_members(turn_context: TurnContext, team_id: str = ""):
                 "TeamsInfo.get_team_members: method is only valid within the scope of MS Teams Team."
             )
 
-        return await TeamsInfo._get_members(TeamsInfo._get_connector_client(turn_context), turn_context.activity.conversation.id)
+        return await TeamsInfo._get_members(
+            TeamsInfo._get_connector_client(turn_context),
+            turn_context.activity.conversation.id,
+        )
 
     @staticmethod
     async def get_members(turn_context: TurnContext) -> List[TeamsChannelAccount]:
         team_id = TeamsInfo.get_team_id(turn_context)
         if not team_id:
             conversation_id = turn_context.activity.conversation.id
-            return await TeamsInfo._get_members(TeamsInfo._get_connector_client(turn_context), conversation_id)
-            
+            return await TeamsInfo._get_members(
+                TeamsInfo._get_connector_client(turn_context), conversation_id
+            )
+
         return await TeamsInfo.get_team_members(turn_context, team_id)
 
     @staticmethod
     def get_teams_connector_client(turn_context: TurnContext) -> TeamsConnectorClient:
         connector_client = TeamsInfo._get_connector_client(turn_context)
-        return TeamsConnectorClient(connector_client.config.credentials, turn_context.activity.service_url)
+        return TeamsConnectorClient(
+            connector_client.config.credentials, turn_context.activity.service_url
+        )
 
         # TODO: should have access to adapter's credentials
-        #return TeamsConnectorClient(turn_context.adapter._credentials, turn_context.activity.service_url)
+        # return TeamsConnectorClient(turn_context.adapter._credentials, turn_context.activity.service_url)
 
     @staticmethod
     def get_team_id(turn_context: TurnContext):
         channel_data = TeamsChannelData(**turn_context.activity.channel_data)
         if channel_data.team:
-            #urllib.parse.quote_plus(
-            return channel_data.team['id']
+            # urllib.parse.quote_plus(
+            return channel_data.team["id"]
         return ""
 
     @staticmethod
     def _get_connector_client(turn_context: TurnContext) -> ConnectorClient:
         return turn_context.adapter.create_connector_client(
             turn_context.activity.service_url
         )
-            
+
     @staticmethod
-    async def _get_members(connector_client: ConnectorClient, conversation_id: str) -> List[TeamsChannelAccount]:
+    async def _get_members(
+        connector_client: ConnectorClient, conversation_id: str
+    ) -> List[TeamsChannelAccount]:
         if connector_client is None:
             raise TypeError("TeamsInfo._get_members.connector_client: cannot be None.")
 
         if not conversation_id:
             raise TypeError("TeamsInfo._get_members.conversation_id: cannot be empty.")
 
         teams_members = []
-        members = await connector_client.conversations.get_conversation_members(conversation_id)
+        members = await connector_client.conversations.get_conversation_members(
+            conversation_id
+        )
 
         for member in members:
             new_account_json = member.serialize()

libraries/botbuilder-core/botbuilder/core/turn_context.py

@@ -8,7 +8,6 @@
 from botbuilder.schema import (
     Activity,
     ActivityTypes,
-    ChannelAccount,
     ConversationReference,
     InputHints,
     Mention,
@@ -377,14 +376,6 @@ def get_mentions(activity: Activity) -> List[Mention]:
         if activity.entities is not None:
             for entity in activity.entities:
                 if entity.type.lower() == "mention":
-                    mention = Mention(
-                        mentioned=ChannelAccount(
-                            id=entity.additional_properties["mentioned"]["id"],
-                            name=entity.additional_properties["mentioned"]["name"],
-                        ),
-                        text=entity.additional_properties["text"],
-                        type=entity.type,
-                    )
-                    result.append(mention)
+                    result.append(entity)
 
         return result

libraries/botframework-connector/botframework/connector/models/__init__.py

@@ -10,4 +10,4 @@
 # --------------------------------------------------------------------------
 
 from botbuilder.schema import *
-from botbuilder.schema.teams import *
+from botbuilder.schema.teams import *