Skip to content

Commit e02cfc4

Browse files
authored
Cherry-picking helpers into master (#535)
* adding teams to connector * makign helpers private * removing unneeded comments * fixing linting * black updates
1 parent c6da323 commit e02cfc4

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

libraries/botbuilder-core/botbuilder/core/teams/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,16 @@
77

88
from .teams_activity_handler import TeamsActivityHandler
99
from .teams_info import TeamsInfo
10-
from .teams_helper import deserializer_helper, serializer_helper
1110
from .teams_activity_extensions import (
1211
teams_get_channel_id,
1312
teams_get_team_info,
1413
teams_notify_user,
1514
)
1615

1716
__all__ = [
18-
"deserializer_helper",
1917
"TeamsActivityHandler",
2018
"TeamsInfo",
2119
"teams_get_channel_id",
2220
"teams_get_team_info",
2321
"teams_notify_user",
24-
"serializer_helper",
2522
]

libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from botbuilder.schema import Activity, ActivityTypes, ChannelAccount
66
from botbuilder.core import ActivityHandler, InvokeResponse, BotFrameworkAdapter
77
from botbuilder.core.turn_context import TurnContext
8-
from botbuilder.core.teams.teams_helper import deserializer_helper, serializer_helper
98
from botbuilder.core.teams.teams_info import TeamsInfo
109
from botbuilder.schema.teams import (
1110
AppBasedLinkQuery,
@@ -23,6 +22,7 @@
2322
TaskModuleResponse,
2423
)
2524
from botframework.connector import Channels
25+
from .teams_helper import deserializer_helper, serializer_helper
2626

2727

2828
class TeamsActivityHandler(ActivityHandler):
@@ -433,12 +433,12 @@ async def on_teams_members_removed(
433433
async def on_teams_channel_deleted( # pylint: disable=unused-argument
434434
self, channel_info: ChannelInfo, team_info: TeamInfo, turn_context: TurnContext
435435
):
436-
return # Task.CompleteTask
436+
return
437437

438438
async def on_teams_channel_renamed( # pylint: disable=unused-argument
439439
self, channel_info: ChannelInfo, team_info: TeamInfo, turn_context: TurnContext
440440
):
441-
return # Task.CompleteTask
441+
return
442442

443443
@staticmethod
444444
def _create_invoke_response(body: object = None) -> InvokeResponse:

0 commit comments

Comments
 (0)