Python 3.11 Compatibility (#2022)

* make updates to run tests with 3.11

* run black

* Update botbuilder-python-ci.yml

* update azure devtools

* remove `azure-devtools` due to it being archived

* remove deprecation warning

* lint ignore test files

* ignore tests folder entirely

* Update .pylintrc

* Update .pylintrc

* Update .pylintrc

* only fail on errors

* Update botbuilder-python-ci.yml

* fixes for lint

* test update pylint version

* remove python 3.11 matrix (to be added in separate PR)

Author: aacebo

.pylintrc

@@ -7,7 +7,7 @@ extension-pkg-whitelist=
 
 # Add files or directories to the blacklist. They should be base names, not
 # paths.
-ignore=CVS,build,botbuilder-schema,samples,django_tests,Generator,operations,operations_async,schema
+ignore=CVS,build,botbuilder-schema,samples,django_tests,Generator,operations,operations_async,schema,tests
 
 # Add files or directories matching the regex patterns to the blacklist. The
 # regex matches against base names, not paths.
@@ -160,7 +160,8 @@ disable=print-statement,
         no-name-in-module,
         too-many-branches,
         too-many-ancestors,
-        too-many-nested-blocks
+        too-many-nested-blocks,
+        attribute-defined-outside-init
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer.py

@@ -256,7 +256,6 @@ async def _recognize_internal(
             LuisPredictionOptions, LuisRecognizerOptionsV2, LuisRecognizerOptionsV3
         ] = None,
     ) -> RecognizerResult:
-
         BotAssert.context_not_none(turn_context)
 
         if turn_context.activity.type != ActivityTypes.message:
@@ -277,7 +276,6 @@ async def _recognize_internal(
                 text=utterance, intents={"": IntentScore(score=1.0)}, entities={}
             )
         else:
-
             luis_recognizer = self._build_recognizer(options)
             recognizer_result = await luis_recognizer.recognizer_internal(turn_context)
 

libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer_v2.py

@@ -18,7 +18,6 @@
 
 
 class LuisRecognizerV2(LuisRecognizerInternal):
-
     # The value type for a LUIS trace activity.
     luis_trace_type: str = "https://www.luis.ai/schemas/trace"
 
@@ -43,7 +42,6 @@ def __init__(
         self._application = luis_application
 
     async def recognizer_internal(self, turn_context: TurnContext):
-
         utterance: str = (
             turn_context.activity.text if turn_context.activity is not None else None
         )

libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer_v3.py

@@ -102,7 +102,6 @@ async def recognizer_internal(self, turn_context: TurnContext):
         return recognizer_result
 
     def _build_url(self):
-
         base_uri = (
             self._application.endpoint or "https://westus.api.cognitive.microsoft.com"
         )
@@ -172,7 +171,6 @@ def _extract_entities_and_metadata(self, luis_result):
         return self._map_properties(entities, False)
 
     def _map_properties(self, source, in_instance):
-
         if isinstance(source, (int, float, bool, str)):
             return source
 

libraries/botbuilder-ai/botbuilder/ai/qna/qnamaker.py

@@ -254,7 +254,6 @@ def _validate_options(self, options: QnAMakerOptions):
     def _has_matched_answer_in_kb(self, query_results: [QueryResult]) -> bool:
         if query_results:
             if query_results[0].id != -1:
-
                 return True
 
         return False

libraries/botbuilder-applicationinsights/tests/test_telemetry_waterfall.py

@@ -65,7 +65,6 @@ async def step2(step) -> DialogTurnResult:
 
         # Initialize TestAdapter
         async def exec_test(turn_context: TurnContext) -> None:
-
             dialog_context = await dialogs.create_context(turn_context)
             results = await dialog_context.continue_dialog()
             if results.status == DialogTurnStatus.Empty:
@@ -119,7 +118,6 @@ async def step2(step) -> DialogTurnResult:
 
         # Initialize TestAdapter
         async def exec_test(turn_context: TurnContext) -> None:
-
             dialog_context = await dialogs.create_context(turn_context)
             await dialog_context.continue_dialog()
             if not turn_context.responded:

libraries/botbuilder-azure/botbuilder/azure/blob_storage.py

@@ -143,7 +143,7 @@ async def write(self, changes: Dict[str, object]):
 
         await self._initialize()
 
-        for (name, item) in changes.items():
+        for name, item in changes.items():
             blob_reference = self.__container_client.get_blob_client(name)
 
             e_tag = None

libraries/botbuilder-azure/botbuilder/azure/cosmosdb_partitioned_storage.py

@@ -146,7 +146,7 @@ async def write(self, changes: Dict[str, object]):
 
         await self.initialize()
 
-        for (key, change) in changes.items():
+        for key, change in changes.items():
             e_tag = None
             if isinstance(change, dict):
                 e_tag = change.get("e_tag", None)

libraries/botbuilder-azure/botbuilder/azure/cosmosdb_storage.py

@@ -178,7 +178,7 @@ async def write(self, changes: Dict[str, object]):
             if not self.__container_exists:
                 self.__create_db_and_container()
                 # iterate over the changes
-            for (key, change) in changes.items():
+            for key, change in changes.items():
                 # store the e_tag
                 e_tag = None
                 if isinstance(change, dict):

libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py

@@ -910,7 +910,6 @@ async def get_user_token(
         magic_code: str = None,
         oauth_app_credentials: AppCredentials = None,  # pylint: disable=unused-argument
     ) -> TokenResponse:
-
         """
         Attempts to retrieve the token for a user that's in a login flow.