Axsuarez/pylint and black hook (#274)

Author: axelsrz

.pre-commit-config.yaml

@@ -0,0 +1,9 @@
+default_stages: [push]
+repos:
+-   repo: https://github.com/pre-commit/mirrors-pylint
+    rev: v2.3.1
+    hooks:
+    -   id: pylint
+        files: libraries
+        args: [--rcfile=.pylintrc]
+        verbose: true

.pylintrc

@@ -7,11 +7,11 @@ extension-pkg-whitelist=
 
 # Add files or directories to the blacklist. They should be base names, not
 # paths.
-ignore=CVS
+ignore=CVS,build,botbuilder-schema,samples,django_tests,Generator
 
 # Add files or directories matching the regex patterns to the blacklist. The
 # regex matches against base names, not paths.
-ignore-patterns=
+ignore-patterns=setup.py,azure_bdist_wheel.py
 
 # Python code to execute, usually for sys.path manipulation such as
 # pygtk.require().
@@ -155,7 +155,8 @@ disable=print-statement,
         cyclic-import,
         too-many-locals,
         too-many-function-args,
-        too-many-return-statements
+        too-many-return-statements,
+        import-error
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

README.md

@@ -6,6 +6,7 @@
 [![Build status](https://fuselabs.visualstudio.com/SDK_v4/_apis/build/status/Python/SDK_v4-Python-CI)](https://fuselabs.visualstudio.com/SDK_v4/_build/latest?definitionId=431)
 [![roadmap badge](https://img.shields.io/badge/visit%20the-roadmap-blue.svg)](https://github.com/Microsoft/botbuilder-python/wiki/Roadmap)
 [![Coverage Status](https://coveralls.io/repos/github/microsoft/botbuilder-python/badge.svg?branch=axsuarez/formatting-and-style)](https://coveralls.io/github/microsoft/botbuilder-python?branch=axsuarez/formatting-and-style)
+[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
 
 This repository contains code for the Python version of the [Microsoft Bot Framework SDK](https://github.com/Microsoft/botbuilder). The Bot Framework SDK v4 enables developers to model conversation and build sophisticated bot applications using Python.  This Python version is in **Preview** state and is being actively developed.
 

libraries/botbuilder-applicationinsights/botbuilder/applicationinsights/application_insights_telemetry_client.py

@@ -103,22 +103,22 @@ def track_exception(
         self,
         exception_type: type = None,
         value: Exception = None,
-        tb: traceback = None,
+        trace: traceback = None,
         properties: Dict[str, object] = None,
         measurements: Dict[str, object] = None,
     ) -> None:
         """
         Send information about a single exception that occurred in the application.
         :param exception_type: the type of the exception that was thrown.
         :param value: the exception that the client wants to send.
-        :param tb: the traceback information as returned by :func:`sys.exc_info`.
+        :param trace: the traceback information as returned by :func:`sys.exc_info`.
         :param properties: the set of custom properties the client wants attached to this data item.
          (defaults to: None)
         :param measurements: the set of custom measurements the client wants to attach to this data item.
          (defaults to: None)
         """
         self._client.track_exception(
-            exception_type, value, tb, properties, measurements
+            exception_type, value, trace, properties, measurements
         )
 
     def track_event(

libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/choice_prompt.py

@@ -3,6 +3,7 @@
 
 from typing import Callable, Dict, List, Union
 
+from recognizers_text import Culture
 from botbuilder.core import TurnContext
 from botbuilder.dialogs.choices import (
     Choice,
@@ -12,7 +13,6 @@
     ListStyle,
 )
 from botbuilder.schema import Activity, ActivityTypes
-from recognizers_text import Culture
 
 from .prompt import Prompt
 from .prompt_options import PromptOptions

libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/datetime_prompt.py

@@ -2,9 +2,9 @@
 # Licensed under the MIT License.
 
 from typing import Dict
+from recognizers_date_time import recognize_datetime
 from botbuilder.core.turn_context import TurnContext
 from botbuilder.schema import ActivityTypes
-from recognizers_date_time import recognize_datetime
 from .datetime_resolution import DateTimeResolution
 from .prompt import Prompt
 from .prompt_options import PromptOptions